Repository navigation
Fix Server::batch_sync call for the current shared crate - #3
Merged
heyitslumi merged 1 commit intoOct 19, 2026
Merged
Conversation
Server::batch_sync now takes &State (&Arc<AppState>) instead of &Arc<Database>, so the call in src/routes/server/install.rs no longer compiles on panel 1.2.6.
Xylo01
added a commit
that referenced
this pull request
Oct 20, 2026
The batch_sync fix (#3) only compiles on panel 1.2.6, so Metadata.toml and the README now say so. urllib ends a read without an error when the connection drops early, and a short mcjars zip was only noted and then unpacked; the received length is now checked against Content-Length and a short file is retried.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server::batch_syncnow takes&State(&Arc<AppState>) instead of&Arc<Database>, so the call insrc/routes/server/install.rsno longer compiles on panel 1.2.6.GetStatederefs toArc<AppState>, the same coercion already used forupdateandinstall_with_optionsin this file.#1
Need help on this PR? Tag
@codesmith-botwith what you need.