fix(a11y): associate search form labels with their inputs - #1354
Open
NakuRei wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
forandidattributes to the search forms on the 404 page, the search page and the search widget so that each<label>is associated with its<input>.Why
The labels are rendered as siblings of the inputs without a
forattribute, so they are not associated with the inputs. Clicking the label does not focus the input, and Chrome DevTools lists the label under Improvements in the Issues panel as "No label associated with a form field".Notes
404.htmlalready hasid="searchInput", which its inline script depends on, so only theforattribute is added there.search-page-input,search-widget-input) use kebab-case like the other ids in the theme.Testing
Checked the 404 page, the search page and the homepage with the search widget in Chrome, before and after the change.
label.controlisnull, clicking the label leaves focus on<body>, and the Issues panel reports the label on all three pages.label.controlis the search input, clicking the label focuses the input, and the Issues panel no longer reports the label.