Documentation update - #92
Merged
Merged
Conversation
The legacy chain-of-responsibility pipeline (model/layout/renderer/ services, DocraftDocument/DocraftDocumentContext) has been fully removed from the codebase; loom is now the only layout/render pipeline. Rewrite the architecture section accordingly, documenting the shared docraft::craft front-end, docraft::backend as surviving low-level libharu infrastructure (not legacy), and native loom charts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015RjTSLobQWMZq8DcFyDZoG
MSVC (VC++ 14.51, -std:c++latest) rejects `static constexpr
std::string kDefaultFont = "Helvetica"` with C2131 ("expression did
not evaluate to a constant... heap allocated during constant
evaluation"), even though the string fits SSO -- GCC/Clang accept it.
Drop constexpr in favor of a plain inline static const std::string,
which needs no constant-evaluation support and behaves identically at
every call site (string concatenation, c_str()).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015RjTSLobQWMZq8DcFyDZoG
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.