-
Notifications
You must be signed in to change notification settings - Fork 413
Add GUI elements to fig.Figure #1943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@lorenzncode this is by far not finished, but I remember you were interested in this. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1943 +/- ##
==========================================
+ Coverage 95.96% 96.40% +0.43%
==========================================
Files 29 29
Lines 7857 9839 +1982
Branches 1174 1558 +384
==========================================
+ Hits 7540 9485 +1945
- Misses 183 212 +29
- Partials 134 142 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
At the moment this is still meant for dogfooding. |
|
@adam-urbanczyk Does this feature only work in Windows? I see that the |
|
Only win CI works out of the box with UI AFAIK and I don't want to maintain something like CQ-editor has/had. The feature as such should work on all systems. What kind of errors are we talking about? |
|
@adam-urbanczyk Here is the error I get. Maybe I'm not setting things up correctly? $ python
Python 3.13.5 (main, Jun 25 2025, 18:55:22) [GCC 14.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from cadquery.fig import Figure
>>> fig = Figure()
Traceback (most recent call last):
File "<python-input-1>", line 1, in <module>
fig = Figure()
File "/home/jwright/repos/cadquery/cadquery/fig.py", line 196, in __init__
self.view = vtk_widgets.VtkRemoteView(
~~~~~~~~~~~~~~~~~~~~~~~~~^
win, interactive_ratio=1, interactive_quality=100
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
)
^
File "/home/jwright/venvs/cq-fig/lib/python3.13/site-packages/trame_vtk/widgets/vtk/common.py", line 690, in __init__
self._helper.has_capabilities("web", "rendering")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'has_capabilities' |
This PR adds a toolbar and minimal objects list to
fig.Figure: