Skip to content

Conversation

@adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Nov 23, 2025

This PR adds a toolbar and minimal objects list to fig.Figure:

image image

@adam-urbanczyk adam-urbanczyk marked this pull request as draft November 23, 2025 15:35
@adam-urbanczyk
Copy link
Member Author

@lorenzncode this is by far not finished, but I remember you were interested in this.

@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

❌ Patch coverage is 98.40000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.40%. Comparing base (fe53ca0) to head (e99d2e7).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
cadquery/fig.py 98.40% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1943      +/-   ##
==========================================
+ Coverage   95.96%   96.40%   +0.43%     
==========================================
  Files          29       29              
  Lines        7857     9839    +1982     
  Branches     1174     1558     +384     
==========================================
+ Hits         7540     9485    +1945     
- Misses        183      212      +29     
- Partials      134      142       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adam-urbanczyk adam-urbanczyk mentioned this pull request Jan 15, 2026
6 tasks
@adam-urbanczyk adam-urbanczyk marked this pull request as ready for review January 27, 2026 17:16
@adam-urbanczyk adam-urbanczyk requested review from jmwright and lorenzncode and removed request for jmwright January 27, 2026 17:17
@adam-urbanczyk
Copy link
Member Author

At the moment this is still meant for dogfooding.

@jmwright
Copy link
Member

@adam-urbanczyk Does this feature only work in Windows? I see that the test_fig test is skipped if not run in a Windows environment and I'm getting some errors in Linux.

@adam-urbanczyk
Copy link
Member Author

Only win CI works out of the box with UI AFAIK and I don't want to maintain something like CQ-editor has/had. The feature as such should work on all systems. What kind of errors are we talking about?

@jmwright
Copy link
Member

@adam-urbanczyk Here is the error I get. Maybe I'm not setting things up correctly?

$ python
Python 3.13.5 (main, Jun 25 2025, 18:55:22) [GCC 14.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from cadquery.fig import Figure
>>> fig = Figure()
Traceback (most recent call last):
  File "<python-input-1>", line 1, in <module>
    fig = Figure()
  File "/home/jwright/repos/cadquery/cadquery/fig.py", line 196, in __init__
    self.view = vtk_widgets.VtkRemoteView(
                ~~~~~~~~~~~~~~~~~~~~~~~~~^
        win, interactive_ratio=1, interactive_quality=100
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/home/jwright/venvs/cq-fig/lib/python3.13/site-packages/trame_vtk/widgets/vtk/common.py", line 690, in __init__
    self._helper.has_capabilities("web", "rendering")
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'has_capabilities'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants