Skip to content

3.8.0 Support#2

Open
NNThomasL wants to merge 2 commits into
CactusPie:masterfrom
NNThomasL:3-8-0
Open

3.8.0 Support#2
NNThomasL wants to merge 2 commits into
CactusPie:masterfrom
NNThomasL:3-8-0

Conversation

@NNThomasL

Copy link
Copy Markdown

Changed the quest logic to the new system found in 3.8.0. Also added the Ground Zero map data. Quite a few of the changed lines in QuestDataService.cs are due to the addition of a foreach loop causing indentation.

@NNThomasL

Copy link
Copy Markdown
Author

I missed the Shoreline map expansion so don't forget to add that when updating the mod.

@potato223qq

potato223qq commented May 4, 2024

Copy link
Copy Markdown

how to compile? I tried it, but I get errors ^this is the first time I compiled^
Screenshot_1

@potato223qq

potato223qq commented May 5, 2024

Copy link
Copy Markdown

Screenshot_1
how do I close these dependencies

@shelmakgc

shelmakgc commented May 14, 2024

Copy link
Copy Markdown

Screenshot_1 how do I close these dependencies

Create a "References" folder inside the CactusPie.Location folder (SPT-Minimap-master\src\CactusPie.MapLocation) and copy there the contents of:
"C:\SPT\BepInEx\plugins\spt"
"C:\SPT\BepInEx\core"
"C:\SPT\SPT\EscapeFromTarkov_Data\Managed"
This should get it working, then just compile it and get all the .dll from "SPT-Minimap-master\src\CactusPie.MapLocation\bin\Debug\net472"

@shelmakgc

Copy link
Copy Markdown

For some reason, after I added the changes of this PR the map worked perfectly, but stopped to work suddenly, now it throws an error on the Bepimex console after starting the raid stating this:
image

No change was made to the plugin, or client, I bet some particular quest is breaking the plugin completelly.
Edit: Confirmed... as with a fresh account it works perfectly... need to investigate the exact issue as the stacktrace doesn't give much info.

For now... at least until I figure what happens, if someone has the same problem just add a try-catch block when calling the quest service, so at least minimap and location work:
image

@potato223qq

Copy link
Copy Markdown

thank you very much

@philneitz

philneitz commented Jun 6, 2024

Copy link
Copy Markdown

For some reason, after I added the changes of this PR the map worked perfectly, but stopped to work suddenly, now it throws an error on the Bepimex console after starting the raid stating this: image

No change was made to the plugin, or client, I bet some particular quest is breaking the plugin completelly. Edit: Confirmed... as with a fresh account it works perfectly... need to investigate the exact issue as the stacktrace doesn't give much info.

For now... at least until I figure what happens, if someone has the same problem just add a try-catch block when calling the quest service, so at least minimap and location work: image

Thank you - could you maybe write that code change down? The screenshot got "cut off"

EDIT: Got it - thanks (heres the line)
try { _questDataService.ReloadQuestData(ZoneDataHelper.GetAllTriggers()); } catch (Exception e) { MapLocationPlugin.MapLocationLogger.LogError($"Exception {e.GetType()} occured. Message: {e.Message}. StackTrace: {e.StackTrace}"); }

Code_SQonS0wq0M

@shelmakgc

shelmakgc commented Jun 6, 2024

Copy link
Copy Markdown

For some reason, after I added the changes of this PR the map worked perfectly, but stopped to work suddenly, now it throws an error on the Bepimex console after starting the raid stating this: image
No change was made to the plugin, or client, I bet some particular quest is breaking the plugin completelly. Edit: Confirmed... as with a fresh account it works perfectly... need to investigate the exact issue as the stacktrace doesn't give much info.
For now... at least until I figure what happens, if someone has the same problem just add a try-catch block when calling the quest service, so at least minimap and location work: image

Thank you - could you maybe write that code change down? The screenshot got "cut off"

EDIT: Got it - thanks (heres the line) try { _questDataService.ReloadQuestData(ZoneDataHelper.GetAllTriggers()); } catch (Exception e) { MapLocationPlugin.MapLocationLogger.LogError($"Exception {e.GetType()} occured. Message: {e.Message}. StackTrace: {e.StackTrace}"); }

Code_SQonS0wq0M

Yeah, just surround the line with a try catch and it will work The line I added after the catch was just informative, so it throwed that message on the console if an error ocoured but all other functionality worked, but it's not needed.
I've not had time to check the problem, but it's surelly related to some temp quests like "kill 5 scavs on shoreline", for now I just avoid to get that quests and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants