Repository navigation
fix(library): hide Ready Templates reset chrome; remove Updates footer modal - #686
Merged
Merged
Conversation
…tes footer modal Ready Templates card badge/reset only tracked visualizer/background/postfx, while apply() resets the full SCENE_KEYS set. Partial reset left layers/ modulation dirty and, with layerStack on, syncStackState re-cleared visualizer to none so the modified badge bounced back without user action. - Align card roots with SVTemplates.SCENE_KEYS + rootOmit for apply preserves - Add resetScene() and use it from resetSection for permanent factory restore - Remove footer download button and Updates modal; keep Settings card only - Tests + README counts 2547
Stop exposing the modified badge and circular reset on Hazır Şablonlar. Users were hitting a misleading partial reset that could bounce the badge back. Gate with hideCardReset: true (+ sectionShowsResetChrome) so chrome can be re-enabled later; SCENE_KEYS roots and resetScene stay in place. Updates footer modal removal unchanged.
CaYatur
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hideCardReset: true+sectionShowsResetChrome). Re-enable later by flipping the flag;SCENE_KEYSroots andresetScene()remain ready.apply(), so the badge could rebound (e.g. with layer stack /syncStackState) without further user action. Not chasing the full bounce-fix in this PR.Test plan
npm test— 2547 pass locally