Repository navigation
release: deprecate --principal-from-client-info, and harden the publish gate - #17
Merged
Merged
Conversation
…sh gate --principal-from-client-info now names its replacement wherever an operator meets it: the startup warning, the --help line, and a CHANGELOG Deprecated section. Removed in 0.3; use --principal-header. It is worth stating why it exists at all, because the reason expires rather than weakens. A v0.1 policy cannot address the principal — SPEC-v0.1 §3.2 refuses agent_eq and every other reserved name at load — so an unauthenticated principal misattributes evidence and cannot widen an outcome. v0.3's authority model makes the principal an authorization input, at which point a self-reported name cannot be one. The publish workflow's sdist gate installed only [dev], so the gateway, ACS, elicitation and OTel modules skipped on exactly the artifacts about to be uploaded — a weaker check than the one on main, guarding an upload to a version number that can never be reused. It installs the extras now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two loose ends, plus one I found while reading the publish workflow before tagging.
--principal-from-client-infois deprecatedIt now names its replacement wherever an operator meets it — the startup warning, the
--helpline, and a CHANGELOG Deprecated section. Removed in 0.3; use--principal-header.The CHANGELOG states why it exists at all, because the reason expires rather than weakens: a v0.1 policy cannot address the principal (SPEC-v0.1 §3.2 refuses
agent_eqand every other reserved name at load), so an unauthenticated principal misattributes evidence and cannot widen an outcome. v0.3's authority model makes the principal an authorization input, at which point a self-reported name cannot be one.The publish gate was weaker than CI
Found while reading
publish.ymlbefore tagging, and worth fixing before an irreversible upload rather than after.The sdist gate ran
pip install ".[dev]", sotest_gateway_server.py,test_acs.py,test_elicitation.pyandtest_otel.pyall skipped — on exactly the artifacts about to be published to a version number that can never be reused. It installs.[dev,gateway,otel]now, matching main.That is the one change here I'd call unrequested, so: it is one line, it strictly increases what is verified before publishing, and I'd rather flag it than have quietly shipped through a gate I knew was thin.
Also
docs/BUILD-PROMPTS-v0.2.md(git-excluded) updated: item 8 is "OpenTelemetry sink + ACS adapter" with T51–T55, and item 0's §9 line no longer says "design note only".Verification
1269 tests pass,
mypy --strict src/,ruff checkandruff format --checkclean. No behaviour changed beyond the warning text.