Skip to content

fix(directory): tests out of the plugin folder, brake precheck names no parent path (#768) - #789

Merged
CSalcedoDataBI merged 2 commits into
mainfrom
move-tests-out-768
Oct 5, 2026
Merged

CSalcedoDataBI merged 2 commits into
mainfrom
move-tests-out-768

Conversation

@CSalcedoDataBI

Copy link
Copy Markdown
Owner

Refs #768. Clears the plugin directory's blocking findings.

  • Secret in a shipped file (\ ests/Board-Work.Grouping.Tests.ps1): the Pester suite moves out of the plugin folder to \ ests/agentic-board/, so it no longer ships to users. Paths are rewritten, and CI, the release zip and CONTRIBUTING are updated.
  • Command reaches above the plugin folder ×3 (\scripts/Brake-PreCheck.sh\ naming .., ../.., ../../..): the walk now climbs from \D:\MIS-REPO\agentic-board\ with \. It covers the same four directories, and a new test pins the depth.

Measured in the portal: 4 blocking → 3 after the tests move (the secret finding went away). This PR also removes the 3 precheck findings; to be confirmed with Re-validate on this branch.

🤖 Generated with Claude Code

CSalcedoDataBI and others added 2 commits October 2, 2026 23:45
…er (#768)

The directory validator scans everything inside the plugin folder as shipped
code. The suite (155 files) carried test fixtures that look like secrets and
helpers that reach outside the folder, and it was dead weight in every user's
install. It now lives in tests/agentic-board/; paths to the plugin are
rewritten from '..' to '../../plugins/agentic-board'. CI, the release zip
and CONTRIBUTING point at the new place.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nt path (#768)

- The previous commit moved tests/ without its path rewrites (they were left
  unstaged), so CI could not find the scripts. This adds them: every test
  reaches the plugin as ../../plugins/agentic-board, and CI, the release zip
  and CONTRIBUTING point at tests/agentic-board.
- Brake-PreCheck.sh: the directory validator blocked it three times
  (COMMAND_PATH_ABOVE_PLUGIN) for spelling ., .., ../.. and ../../.. in its
  walk. It now climbs from \D:\MIS-REPO\agentic-board with \ - the same four directories,
  no extra process - and a test pins both the depth (found at cwd+3, not +4)
  and that no non-comment line names '..'.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@claude

claude Bot commented Oct 5, 2026

Copy link
Copy Markdown

Sin hallazgos bloqueantes. Revisé el recorrido de Brake-PreCheck.sh (cwd, +1, +2, +3, igual que antes; los bordes / y /foo están bien manejados) y las rutas de CI, release y CONTRIBUTING.

Nit menor: el cuerpo del mensaje del commit quedó corrupto (\D:\MIS-REPO\agentic-board with \), porque se expandió una variable de shell al escribirlo. Conviene corregirlo antes del squash.

@CSalcedoDataBI
CSalcedoDataBI merged commit c38dc8c into main Oct 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant