Open
Conversation
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
|
Note It appears that this Pull Request modifies the On inspection, the No further action is required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
climpredandxskillscoreto latest versions.pytestwithnbval.08_Getting_and_bias_correcting_CMIP6_data.ipynbnow skips the execution of the last three cells (a warning is posted in the notebook that these cells are very long to compute already).Perform_a_climate_change_impact_study_on_a_watershed.ipynbno longer sets anumpyrandom seed (no longer supported in modern versions).Does this PR introduce a breaking change?
Yes.
The latest
xskillscore(v0.0.29) andclimpred(v2.6.0) are now required. These versions address several deprecations fromxarrayandnumpyand the packages are generally cleaner. They remain backwards-compatible to Python 3.10.The dependencies found in
environment-docs.ymlnow contain only the dependencies needed for RavenPy and the dependencies needed to render the documentation without running the notebooks. These dependencies should eventually be synchronized with thedocsrecipe withinpyproject.tomlThe dependencies found in
environment-dev.ymlnow include the dependencies needed to run tests against the notebooks. These dependencies should be added to their own recipe (notebooks) within pyproject.toml.Other information:
The Makefile is quite out of date and could benefit from several recipes found in other Ouranos projects. After the next cookiecutter update, we should consider addressing this.
The cookiecutter this project is based on has significantly changed the way that non-library dependencies are installed (
[dependency-groups]/ PEP 735). In the next refresh, the newdocsandnotebooksdependency lists should be added to this newpyproject.tomlentry.