feat(grid): default filter setting, tighter header, drop refresh button (0.5.0) - #16
Merged
Merged
Conversation
…on; 0.5.0 - Add a "Default Reading List filter" setting (All / To Read / Reading / Read / Favorites). The grid opens on it every time the page opens; a filter argument on the renderer macro still wins. Pure resolver in src/filters.ts with unit tests. - Fix the gap between the page title and the filter chips: the grid inherited Logseq's block-content white-space:pre-wrap, which rendered the template's newlines/indentation as two blank 21px lines. Set white-space:normal on the grid; drop the bar's 4px top margin. - Remove the refresh button. The query re-runs on every page open; "Reading List: refresh grid" stays in the command palette. - Bump the dompurify override 3.4.12 -> 3.4.14 (GHSA-55q2-fjhq-7xh7), which the npm-audit CI gate would otherwise fail on. - README and CHANGELOG updated; CHANGELOG cut as 0.5.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TT8Y9w6w2kLuBgcUWqVJpc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
{{renderer :reading-list, reading}}) still takes precedence. The resolver is a pure function insrc/filters.ts, with tests intests/filters.test.ts.white-space: pre-wrap, so the newlines and indentation in our HTML template rendered as two blank 21px text lines above the chip bar..lrl-readinglistnow setswhite-space: normal, and the bar's 4px top margin is gone. The chips now sit where the first bullet sits on a normal page.dompurifyoverride from 3.4.12 to 3.4.14 for GHSA-55q2-fjhq-7xh7 (moderate XSS; fixed in 3.4.13). Without it thenpm audit --omit=devgate fails.Why it changed
Testing instructions
npm test(54 passing, 10 new),npm run typecheck,npm run build,npm audit --omit=dev(0 vulnerabilities)..lrl-readinglistand.lrl-bar). Reproduced in headless Chromium underpre-wrap(42px) and confirmed at 0px with the fix.Self-review
Checked correctness and edge cases: unknown or non-string setting values fall back to
all; macro args are case- and space-insensitive;rlRefreshis kept for the command palette. For XSS,resolveInitialFilteronly ever returns values from a fixed list, so nothing user-controlled reaches the markup. Blast radius: thewhite-spacechange is scoped to.lrl-readinglist.Known (not shipped): dev-only advisories in the Parcel/Vitest toolchain. They're noted in the changelog under Known issues and will get a follow-up.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TT8Y9w6w2kLuBgcUWqVJpc