chore(ci): SHA-pin actions, drop deprecated release-upload steps (audit bucket 6 — L2) - #7
Merged
Merged
Conversation
…it L2) Pin ncipollo/release-action and the first-party actions/checkout & actions/setup-node to full commit SHAs (with version comments) instead of mutable major tags, so a moved tag can't substitute action code. Dependabot's github-actions updates maintain the pins. In publish.yml, remove the two archived actions/upload-release-asset@v1 steps — ncipollo/release-action attaches the zip + package.json via its 'artifacts' input — and add explicit least-privilege 'permissions: contents: write'. The release zip now embeds the tag via github.ref_name (was computed separately for the removed upload step). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019cVCdCtNzUJmy1yen3JyBk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Audit bucket 6, finding L2 — the final one.
ncipollo/release-action,actions/checkout,actions/setup-node) to full commit SHAs with version comments, acrossci.ymlandpublish.yml. A moved/hijacked tag can no longer substitute action code; Dependabot's github-actions updates keep the pins current.actions/upload-release-asset@v1steps inpublish.yml.ncipollo/release-actionattaches the release zip +package.jsonvia itsartifactsinput, so they were redundant (and the action has been unmaintained since 2021).permissions: contents: writetopublish.yml(it had none, relying on the repo default).github.ref_name(previously computed separately only to name the upload-asset).Testing
ci.ymlis exercised by this PR's own CI run (build/test/typecheck).publish.ymlis tag-triggered and can't run on a PR. YAML validated; the asset wiring is a straightforward ncipolloartifactsswap. Verify the next release (or cut a throwaway tag) attacheslogseq-ical-sync-<tag>.zip+package.json.Reviewer note
No automated PR reviewer configured; self-reviewed — SHAs resolved from the current major tags, least-privilege permissions, no secrets.
🤖 Generated with Claude Code
https://claude.ai/code/session_019cVCdCtNzUJmy1yen3JyBk