feat(manager-fallback): Added manager fallback#419
Merged
VoyTechnology merged 1 commit intodevelopfrom Apr 19, 2018
Merged
Conversation
da7ceca to
189c9fe
Compare
This is a functional version of the new heracles architecture.
Member
Author
|
Merged using admin privileges, without code review, for sprint purposes. Please see #420 for tracking issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a functional fallback version of the new heracles architecture. It is designed to full job processing pipeline.
It contains all functionality of the normal manager (after #418), It is however slightly deficient and not as fully featured as the Rust version. The main are:
Known issues, possibly originating and related to the old worker rewrite include:
Some of the above issues can be "fixed" by purging the RabbitMQ queue
Note: the logging is commented out in
workerdue to weird issues on my machine. They are serving informational purpose only and are non essential to the working of the project.