Release Candidate - CWA - #2185
Open
kramduny-cps wants to merge 10 commits into
Open
kramduny-cps wants to merge 10 commits into
kramduny-cps wants to merge 10 commits into
Conversation
* Fix brokien build * Handle Non-Ascii characters in document file name safely so that they don't throw exception
…ents njs CORS handling (#2180)
Co-authored-by: dbarber-cps <Daniel.Barber@cps.gov.uk>
…2183) * RMAT-242: Fix for proxy on Prod * RMAT-242: route CMO load-balancer sessions to the default upstream C-CMO-LBsessioncookie was detected as env 'cmo', which has no configured upstream, so the DDEI /CMS call proxied to an undefined host and returned no redirect (CmsException 'Could not extract CMS version ID'). In UAT the default upstream is cmo.cps.gov.uk, so route CMO sessions to the default env - restoring the pre-RMAT-242 behaviour. * RMAT-242: mirror the CMO fix into the next proxy config cms-detection.js (the un-deployed 'next' config's cms-env primitive) had the same latent bug as the live cmsenv.js: cmo has no configured upstream, so mapping mod/cmo cookies to env 'cmo' would proxy to an undefined host. Route them to 'default' instead, matching the live fix. Updates the characterisation test and a stale comment in cms-proxy.js accordingly. * Fix checkov CKV_DOCKER_3 on test-only proxy integration Dockerfiles Both containers are local integration-test fixtures (not deployed), and already documented why they deliberately run as root: Dockerfile.nginx needs the master process bound to root to listen on port 80 and drop worker privileges per nginx.conf's own 'user nginx;' directive; Dockerfile.mock listens on the privileged port 443 to answer the hardcoded App Insights hostname. Added #checkov:skip=CKV_DOCKER_3 annotations with those reasons, matching the skip convention already used elsewhere in this repo's Terraform files, rather than adding a USER directive that would break either container. * Update cms-detection.js * Update cms-detection.unit.test.js --------- Co-authored-by: dbarber-cps <Daniel.Barber@cps.gov.uk> Co-authored-by: Kesh Ramduny <Keshav.Ramduny@cps.gov.uk>
* Fix brokien build * Removing add witness and add action from reclassification * refactor endpoint
* change header to 1 decimal place * refactor warning logs
* Fix brokien build * disable reclassification of document type * update unit test to cover all document types * remove dup est
… in CMS auth handover (#2188)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://cpsgovuk.atlassian.net/projects/RMAT/versions/22511/tab/release-report-all-issues