Skip to content

Release Candidate - CWA - #2156

Merged
dbarber-cps merged 35 commits into
mainfrom
development
Sep 8, 2026
Merged

dbarber-cps merged 35 commits into
mainfrom
development

Conversation

@dbarber-cps

Copy link
Copy Markdown
Collaborator

No description provided.

cpsgopisivanappanvasanthi and others added 25 commits July 24, 2026 09:59
* Initial Commit - GetCaseSummaryAsync replaced from MasterDataService instead of MDS Client.

* Initial Commit - GetCaseSummaryAsync replaced from MasterDataService instead of MDS Client.

* Audit Changes - MDS Client Switch

* aspose license file on coorindator project ignored

* GetCaseSummary Moved from MDS Client to Master Data Service Client

* mdsclient modified to masterdataserviceclient for getcasesummary end point.

* Removed the unwanted dto

* Corrected few more code in the PR

* Rmoved unwanted requests

* Removed unwanted using statements

* All PR feedback implemented

* gitignore modified

* Added the case id for the response object.

* Owning Unit Added to the object mapping
* Add CaseUrnResolver

* Rename current endpoint and routes to Legacy

* fix log placeholder
* bulk redaction search api separated

* added logging

* addressed pr comments

* removed unused code

* refactor sonarqube errors
* FCT-20777 Creating a new endpoint for PDF Generator without URN

* FCT-20777 - PR f/b changes
* FCT2-20774: Rename Legacy Coordinator Endpoints

* Rename files
…out URNs - PDF Redactor (#2127)

* FCT-20778 - creating new endpoints for Redact and ModifyDocument wihtout URNs - PDF Redactor

* FCT-20778 SonarCloud fixes in RedactPdfLegacy

* FCT-20778 - removing unused documentId from new RedactPDF endpoint route
* remove urn from bulk redaction endpoints

* Update MasterDataService config in terraform

* refactor how CmsAuthValues is created

---------

Co-authored-by: Kesh Ramduny <Keshav.Ramduny@cps.gov.uk>
* FCT 20780 - Creating text-extractor endpoints without URN

* FCT 20780 - sonarcube fixes

* FCT 20780 - PR f/b - adding header and adjusting fieldnames to be consitent with other projects
…t to 'unknown' state (#2133)

* Ensure that materials not matched with mapping data are set to 'unknown' state

* fixing unit tests
* Ensure that materials not matched with mapping data are set to 'unknown' state

* fixing unit tests

* change type to comm

* change category to communication for unknowdocument type id
* FCT2-21165: Text removed from Document after Redaction

* FCT2-21165 - Upgraded the Aspose.PDF.Drawing version alone to a higher version for pdf-redactor to fix this issue. Based on the need we can move this upgrade to other azure functions.

---------

Co-authored-by: Kesh Ramduny <Keshav.Ramduny@cps.gov.uk>
…w-and-manage-materials-and-communications-buttons (#2147)
* created new endpoints in coordinator app

* sonarqube issues addressed

* refactor exception for sonarqube
* Proxy changes for UAT

* #FCT2-18732,#FCT2-19744 - add UAT outsystems domain to global components CORS whitelist

* Update IP

* fix dev vars

* changing az login behaviour to support password with "-" at start

* updating similar az login commands to support password with "-" at start

* corrected indentation causing syntax error

* Update Whitelist for UAT

* Update global-components.conf

* Update .env.uat

* Update main.tf

* Update main.tf

* Bugfix/fct2 20301 uat environment nginx config (#2089)

* #FCT2-20301 - uat nginx config handover tweak

* #FCT2-20301 - uat nginx config handover tweak

* enable global nav on UAT

---------

Co-authored-by: Stef Stachow <stef@stachow.co.uk>
Co-authored-by: Daniel Barber <daniel.barber@cps.gov.uk>
Co-authored-by: shellisj-spc <James.Shellis@cps.gov.uk>
* replace telemetry with ILogger

* tidy up

* refactor search case

* Fix Sonarqube comment

* Sonarqube fix

* SonarQube

* Sonarqube

* fix broken unit test
Comment thread polaris-devops-pipelines/scale-set/steps/create-build-agent-image.yml Dismissed
Comment thread polaris-devops-pipelines/scale-set/steps/create-build-agent-image.yml Dismissed
Comment thread polaris-devops-pipelines/scale-set/steps/update-image-version.yml Dismissed
Comment thread polaris-gateway/Functions/PolarisPipelineBulkRedactionSearchStart.cs Dismissed
kramduny-cps
kramduny-cps previously approved these changes Aug 24, 2026
* refactored existing and created new gateway endpoints

* refactored old legacy endpoint tests

* addressed comments

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secrets Audit found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

benrome-cps and others added 3 commits August 26, 2026 11:36
…2141)

* FCT2-11937-improve-error-handling-500-errors-defendants-and-charges

* FCT2-11937-improve-error-handling-500-errors-defendants-and-charges

* FCT2-11937-improve-error-handling-500-errors-defendants-and-charges
* Fix brokien build

* initial commit

* fix warnings

* remove unused caseUrn ref

* clean up tests
kramduny-cps
kramduny-cps previously approved these changes Aug 28, 2026
…dy up (#2163)

* Fix brokien build

* fix rte to pdf conversions for large files
TahmeedAhmed-NTT-CPS and others added 2 commits September 2, 2026 13:29
* refactoring restapi

* addressed refactoring pr comments

* revert cancellation token removal
…2139)

* #FCT2-12207 - proxy test harness (integration + unit) and refactor docs

Add polaris-terraform/main-terraform/proxy/: a golden-master test harness for
the nginx CMS proxy, plus the refactor planning docs. No change to the operational
config — these tests characterise the current behaviour so the planned refactor
(feature-sliced includes, cmsenv.js -> common.js) can be proven behaviour-preserving.

- integration/: Docker (real nginx.conf + njs vs a mock upstream), one test file
  per feature, 115 tests; every nginx.conf location exercised.
- unit/: dependency-free njs unit tests for cmsenv.js and nginx.js, 68 tests.
- docs/: PROXY.md (settings/feature/architecture), SYSTEM.md, QUIRKS.md
  (bugs/oddities found while testing), PLAN.md.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* #FCT2-12207 - add parallel "next" config + dual-target integration tests

Stage the refactor without touching the operational config:

- proxy/config/: a verbatim copy of the live nginx config (nginx.conf, njs,
  global-components), to be sliced into per-feature includes / common.js in place.
  NOT wired to terraform, NOT deployed.
- docker-compose.next.yml: override that repoints the config mounts at proxy/config/
  (Compose merges volumes by target, so it only lists the sources it changes).
- run-tests.sh --next: runs the identical suite against the next config.

Both configs pass all 115 integration tests today (config/ is a byte-for-byte copy),
proving the dual-target plumbing before any location moves. Keep --next green at each
migration step.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* #FCT2-12207 - slice next config into per-feature includes (all 46 locations)

Location-slicing phase of the refactor (docs/PROXY.md §6), done entirely in the
non-operational proxy/config/ — the live config is untouched.

- Every location block moved out of config/nginx.conf into features/*.conf, one
  file per feature (00-health … 06-polaris-ddei, xx-redundant). Parent nginx.conf
  is now just the server preamble + `include features/*.conf;`.
- All 5 CMS regexes kept together and in order in 05-cms-proxy.conf (the
  first-match-wins ordering contract, §5).
- njs unchanged: nginx.js/cmsenv.js still imported by the parent; feature blocks
  call them across the include boundary. The njs -> common.js/auth-handover.js
  split is the next phase.
- docker-compose.next.yml mounts each feature file; ./run-tests.sh --next runs the
  identical suite against the sliced config.

Both configs pass all 115 integration tests — the sliced config behaves identically
to the live monolith.

* #FCT2-12207 - pre-cmsenv.js refactor

* #FCT2-12207 - code split completed

* #FCT2-12207 - first pass refactoring of proxy features

* #FCT2-14290 - adding a script into proxied-CMS

* #FCT2-12207 - first pass refactoring of proxy features

* #FCT2-12207 - add polaris-ddei alternate config

* #FCT2-12207 - add polaris-ddei alternate config

* #FCT2-12207 - centralised ie/edge mode switching code

* #FCT2-12207 - add entra auth as drop 2

* #FCT2-12207 - added case locking

* #FCT2-12207 - added cms augmentation logic

* #FCT2-12207 - code tidy; make new app settings optional

* #FCT2-12207 - merge from developmnt; merge in cpt env additional

* #FCT2-12207 - tweak integration test logic to accommodate cpt differences until main is fixed

* #FCT2-12207 - comment tidyup

* #FCT2-12207 - comment tidyup

* #FCT2-12207 - comment tidyup

* #FCT2-12207 - remove experimental case presence code

* #FCT2-12207 - remove experimental case presence code

* #FCT2-12207 - PR fixes

* #FCT2-12207 - address PR feedback. Auth handover HMAC; ENTRA setting defaults removed from config files
Comment thread polaris-terraform/main-terraform/proxy/tests/integration/docker/Dockerfile.mock Dismissed
Comment thread polaris-terraform/main-terraform/proxy/tests/integration/docker/Dockerfile.nginx Dismissed
benrome-cps and others added 2 commits September 3, 2026 11:21
* refactor word search pattern

* sonarqube issue fixed

* simplified solution

* revert back to prev solution

* refactor padding
@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
12.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@dbarber-cps
dbarber-cps merged commit 4850504 into main Sep 8, 2026
92 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

10 participants