Skip to content

story/FCT2-20672- text content update for the unauthorised page - #584

Merged
renjithabby merged 1 commit into
mainfrom
story/FCT2-20672-unauthorised-page
Sep 21, 2026
Merged

renjithabby merged 1 commit into
mainfrom
story/FCT2-20672-unauthorised-page

Conversation

@renjithabby

@renjithabby renjithabby commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

https://cpsgovuk.atlassian.net/browse/FCT2-20672

PR checklist

Tick what applies before you raise. Delete anything that doesn't.

Correctness

  • Does what the ticket asks for
  • Handles the edge cases (empty, null, zero, large inputs), not just the happy path
  • Errors are handled, not swallowed
  • New logic has tests, including the failure cases
  • Tests assert something real, not just run the code

Keeping it simple

  • Doesn't rebuild something that already exists in the codebase
  • No more complex or slower than it needs to be
  • No leftover debug logging or commented-out code

Code Quality

  • Pre-commit hooks were run for all commits in this PR

Easy to miss (a green pipeline won't flag these)

  • One logical change, not a pile of unrelated stuff

If you touched the UI

  • API changes are reflected in the MSW handlers in src/mocks and the matching zod schema, so the mocked tests aren't passing against a contract that's gone
  • New config or feature flags are wired into the VITE build variables, not just added in code
  • Data fetches handle the loading, empty and error states, not just success, and match how the rest of the app already does it
  • Ran prettier (npm run prettier:format), since CI lints but doesn't check formatting
  • Checked accessibility (keyboard nav, screen reader, sensible labels), since the Lighthouse run is manual and won't flag it for you

@sonarqubecloud

sonarqubecloud Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

@renjithabby
renjithabby merged commit 95bb625 into main Sep 21, 2026
11 checks passed
@renjithabby
renjithabby deleted the story/FCT2-20672-unauthorised-page branch September 21, 2026 09:15
HasanCPS pushed a commit that referenced this pull request Sep 23, 2026
* filtering status telemetry (#581)

* filtering status telemetry

* fix nuget

* pr comment fixes

* add version to dotnet build

* deploy envs conditionally, require manualvalidation only for prod

* story/FCT2-20672 : Text content update for the unauthorised page (#584)

* add separate pipeline yaml for development trigger

* unblock E2E Tests in Dev

* test release versioning in dev

* test release versioning in dev

* use var instead of parameter for buildConfiguration

* remove temorary test lines

* task/FCT2-21994 backend test pipeline - rm redundant build job (#585)

* egress delete check all files successful (#586)

* Fct2 21924 bulk delete unknown files (#587)

* deletion of unexisting files

* deletion of existing files

* update parameter empty string value option

* trigger integration tests only for debelopment

* rm unused parameters, fix stage dependency

* fix stage dependency

---------

Co-authored-by: Rhys Bridges <rhys.bridges@cps.gov.uk>
Co-authored-by: Renjith Abby <renjithabby@gmail.com>
HasanCPS added a commit that referenced this pull request Sep 23, 2026
* filtering status telemetry (#581)

* filtering status telemetry

* fix nuget

* pr comment fixes

* story/FCT2-20672 : Text content update for the unauthorised page (#584)

* task/FCT2-21994 backend test pipeline - rm redundant build job (#585)

* egress delete check all files successful (#586)

* Fct2 21924 bulk delete unknown files (#587)

* deletion of unexisting files

* deletion of existing files

---------

Co-authored-by: Rhys Bridges <rhys.bridges@cps.gov.uk>
Co-authored-by: Renjith Abby <renjithabby@gmail.com>
Co-authored-by: Lilach <Lilach.Davis@cps.gov.uk>
lilachdavis added a commit that referenced this pull request Sep 28, 2026
* filtering status telemetry (#581)

* filtering status telemetry

* fix nuget

* pr comment fixes

* story/FCT2-20672 : Text content update for the unauthorised page (#584)

* task/FCT2-21994 backend test pipeline - rm redundant build job (#585)

* egress delete check all files successful (#586)

* Fct2 21924 bulk delete unknown files (#587)

* deletion of unexisting files

* deletion of existing files

---------

Co-authored-by: Rhys Bridges <rhys.bridges@cps.gov.uk>
Co-authored-by: Renjith Abby <renjithabby@gmail.com>
Co-authored-by: Lilach <Lilach.Davis@cps.gov.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants