test(e2e): assert the Add action is the first offence results column - #242
Closed
kmshrajcps wants to merge 1 commit into
Closed
kmshrajcps wants to merge 1 commit into
kmshrajcps wants to merge 1 commit into
Conversation
The column move itself shipped in #229; this covers it against the real /api/v1/offences response, where previously only the MSW integration suite asserted the order. Scenario 21 drives a suspect journey to the offence search page and checks the rendered table: one ordered comparison over the header cells covers both halves of the acceptance criteria - Actions is first, and it comes before CJS code, Description, Statute name and section and Effective dates. Header order alone would still pass with the Add link moved to another cell, so it also asserts the link is in the first column and the CJS code is the column that follows it. Both assertions were falsified before being kept: expecting CJS code first fails on the header comparison, and looking for the Add link in the second cell fails with the element not found.
|
Contributor
Author
|
as this PR #252 is raised, closing this |
Contributor
Author
|
as other PR is raised #252 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding test to assert the Add action is the first offence results column