Repository navigation
Fix artifact listing column alignment - #371
Closed
Sebastians007 wants to merge 1 commit into
Closed
Sebastians007 wants to merge 1 commit into
Sebastians007 wants to merge 1 commit into
Conversation
…gned Closes #356. This project has no Tailwind build; src/index.css hand- defines each utility class JSX uses. The artifact listing's header and rows used w-20/w-24/w-28/w-36/w-56/w-64 and min-w-max, none of which existed in index.css, so those classes silently no-opped and every column sized to its own content instead of a fixed width — long values (e.g. a full artifact UUID) pushed later columns out of alignment with the header. Added the missing width/min-width utilities, plus min-w-0 on the truncating columns and their inner flex wrappers so long IDs/names ellipsis instead of growing the row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
w-20,w-24,w-28,w-36,w-56,w-64,min-w-max) that don't exist insrc/index.css(this project hand-defines its own utility classes rather than building with Tailwind). Undefined classes are silently ignored, so each column sized to its own content instead of a fixed width — a long artifact ID (e.g. a full UUID) pushed every later column out of alignment with the header.src/index.css.min-w-0to the truncating columns (ID, Artifact Name) and the Assignee/Reporter avatar wrappers insrc/pages/Artifacts.jsso long values ellipsis instead of expanding the row.Closes #356
Test plan
react-scripts test --testPathPattern=Artifacts) — 65 tests, 3 suites, all passing.