bug: default configuration does not work on linux vms#101
Open
Paul2803k wants to merge 2 commits intodevelopmentfrom
Open
bug: default configuration does not work on linux vms#101Paul2803k wants to merge 2 commits intodevelopmentfrom
Paul2803k wants to merge 2 commits intodevelopmentfrom
Conversation
the host.docker.internal notation is not support in every version of docker https://commandlinux.com/qa/host-docker-internal/. To fix this we provide a fallback. src: https://abhihyder.medium.com/fixing-host-docker-internal-issue-in-docker-compose-on-linux-f733006dfa12
There was a problem hiding this comment.
Pull request overview
Addresses Linux VM setups where host.docker.internal is not available by ensuring the hostname resolves via a Compose-provided host mapping.
Changes:
- Add
extra_hosts: "host.docker.internal:host-gateway"to the production Compose service. - Add the same
extra_hostsmapping to the dev Compose service. - Update
.env.examplecomments to describe thathost.docker.internalis resolved via Compose mapping.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docker-compose.yml | Adds an extra_hosts mapping so host.docker.internal resolves on Linux. |
| docker-compose.dev.yml | Adds the same host mapping for the dev container. |
| .env.example | Updates comments explaining how host.docker.internal is resolved. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the host.docker.internal notation is not support in every version of docker.
To fix this we provide a fallback.
src of the fix: https://abhihyder.medium.com/fixing-host-docker-internal-issue-in-docker-compose-on-linux-f733006dfa12