Conversation
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry I had accidentally pushed a first version of this to main. Here is my second version under this branch. On the creation of this pull request, a test build should run. wirelesslink.signed.bin will be present in the dfu_application.zip, this can be found in the build artifacts. I flashed the .bin to my smartcharger and confirmed a few features.
The .bin being in the artifacts is somewhat unfortunate because there is a maximum retention period of 90 days. So access to the .bin is lost after that period unlike release artifacts. It would be nice to
Next step is to fix the build summary and implement a second build for WL_IN_CHARGER = false to have both versions ready in the artifacts.