Heat budget#628
Open
Hangyum wants to merge 2 commits into
Open
Conversation
…s in ACCESS-OM2 using online diagnostics.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
|
@Hangyum just checking, do you want others to review this PR now, or is it still a draft you’re working on? |
Collaborator
Author
|
I think it is ready for someone to review if it is just a heat budget recipe. It will be a draft PR if we also need to add something about the salnity budget diagnostics. |
Collaborator
|
This seems like a new recipe to me, is this right? Could we update the PR title to reflect this? Also the first comment on the PR implies that the PR is fixing something and not adding a new recipe. I'm a bit confused.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just resolved one display error shown in the heat budget instruction, and loaded the datasets using Intake Catalog in this commit.