Repository navigation
Add time-boxed Snyk ignores for 9 Spring findings with no Boot 3.x fix (expire 2027-02-15) - #1271
Conversation
…xes (expire 2027-02-15) Co-Authored-By: joel.oshea <joel.oshea@cognition.ai>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
There was a problem hiding this comment.
Devin Review found 2 findings. All 2 findings are left for you to triage below.
| SNYK-JAVA-ORGSPRINGFRAMEWORKGRAPHQL-19267447: | ||
| - '*': | ||
| reason: >- | ||
| CVE-2026-59286 in org.springframework.graphql:spring-graphql 1.4.6 (GraphiQL loaded from a CDN). Time-boxed ignore approved by Joel O'Shea on 2026-11-17. | ||
| No fix on Boot 3.x; the fix needs Spring for GraphQL 2.0.5 (Spring Boot 4). | ||
| Exposure: YES, revisit. GraphiQL is enabled and public at /graphiql and loads its scripts from esm.sh. | ||
| expires: 2027-02-15T00:00:00.000Z |
There was a problem hiding this comment.
🟨 Public GraphiQL CDN exposure suppressed
With SNYK-JAVA-ORGSPRINGFRAMEWORKGRAPHQL-19267447 ignored, Snyk stops flagging the exposed CDN finding. Public GraphiQL still loads its scripts from esm.sh, leaving visitors exposed until the page is disabled or changed.
Devin left this for you to triage: Joel approved this ignore, and the PR lists it under Exposed: revisit, but the risk is real: the public /graphiql page loads its scripts from esm.sh until it is changed. Recommend a follow-up ticket to disable GraphiQL (spring.graphql.graphiql.enabled=false / dgs.graphql.graphiql.enabled=false) or vendor its assets. That is out of scope here, because the instruction was to add only the 9 ignores, and it changes /graphiql behaviour.
Was this helpful? React with 👍 or 👎 to provide feedback.
| SNYK-JAVA-ORGSPRINGFRAMEWORKGRAPHQL-19267450: | ||
| - '*': | ||
| reason: >- | ||
| CVE-2026-59288 in org.springframework.graphql:spring-graphql 1.4.6 (CSRF via the GraphiQL page). Time-boxed ignore approved by Joel O'Shea on 2026-11-17. | ||
| No fix on Boot 3.x; the fix needs Spring for GraphQL 2.0.5 (Spring Boot 4). | ||
| Exposure: YES, revisit. GraphiQL is enabled and public at /graphiql. | ||
| expires: 2027-02-15T00:00:00.000Z |
There was a problem hiding this comment.
🟨 Public GraphiQL CSRF exposure suppressed
With SNYK-JAVA-ORGSPRINGFRAMEWORKGRAPHQL-19267450 ignored, Snyk stops flagging the exposed CSRF finding. Public GraphiQL remains enabled without a mitigation, so visitors can still reach the affected page.
Devin left this for you to triage: Joel approved this ignore, and the PR lists it under Exposed: revisit; the public /graphiql page stays reachable. Recommend the same follow-up as finding 0001: disable or lock down GraphiQL. That is out of scope for this ignores-only change.
Was this helpful? React with 👍 or 👎 to provide feedback.
81795ad
into
devin/unt-5-spring-boot-2.7
Summary
Part 2 of UNT-13. Joel approved this on 2026-11-17. The PR adds the 9 remaining Spring Snyk findings that fail
security/snykon #1252 to.snyk. None of them has a fix on the Spring Boot 3.x line: the fixes are only in Spring Framework 7.0.9, Spring Security 7.0.7 and Spring for GraphQL 2.0.5 (all Spring Boot 4)..snyknow has 10 ignores: the existing CVE-2026-47890 entry from Add time-boxed Snyk ignore for CVE-2026-47890 in spring-webmvc 6.2.19 (expires 2027-02-15) #1269 plus these 9. Each one uses path*,expires: 2027-02-15T00:00:00.000Z, and a reason that names the CVE, Joel's approval, the fix version and a one-line exposure note. There are no wildcard ids, severity thresholds or org-policy changes.docs/upgrade/security-exceptions.mdnow has a table of all 10 exceptions (Snyk ID, CVE, package, severity, exposed, why, expiry) and an Exposed: revisit section.Exposed: revisit
/graphiqlredirects to/graphiql?path=/graphql, which returns 200 and loads its scripts fromesm.sh;WebSecurityConfigpermits/graphiql.TrailingSlashConfigmapsUrlHandlerFilterto/**, but inwrapRequest()mode. Probes such as//evil.example/and/\evil.example/returned 400 with noLocationheader.The other 6 findings are not exposed. The table gives the reason for each.
Verified locally on JDK 17:
./gradlew clean spotlessCheck testpasses (77 tests, 0 failures).scripts/smoke/run.shpasses (81 calls matchscripts/smoke/baseline.jsonl).Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/c41fb509304f43fd9546fd698a4c8c67
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/c41fb509304f43fd9546fd698a4c8c67?variant=devin
Requested by: @joeloshea-cog
👀 2 findings for you to triage · Follow Devin's work