Skip to content

test: extra coverage for empty feed pages (PR #1267) - #1268

Open
devin-ai-integration[bot] wants to merge 1 commit into
devin/task-28-feed-empty-pagefrom
devin/tests-for-pr-1267
Open

devin-ai-integration[bot] wants to merge 1 commit into
devin/task-28-feed-empty-pagefrom
devin/tests-for-pr-1267

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Summary

Adds tests for the fillExtraInfo empty-list guard in ArticleQueryService from #1267. Targets devin/task-28-feed-empty-page.

  • ArticleQueryServiceUnitTest (new, Mockito): an empty findUserFeed / findUserFeedWithCursor page never calls articlesFavoriteCount, userFavorites or followingAuthors. Those mappers build IN (...) from the id list, so an empty list produced invalid SQL and the 500.
  • ArticleQueryServiceTest (DB):
    • you follow a user who has no articles → empty offset page (count == 0) and empty cursor page
    • a PREV cursor before the first article → empty page, hasPrevious == false
  • ListArticleApiTest: GET /articles/feed?offset=20&limit=20 returns 200 with articles: [] and articlesCount set to the total.

Verification gap: the new tests compile (compileTestJava) and are formatted with google-java-format. ./gradlew spotlessJavaApply test could not run in the session: the network policy blocks the Maven mirror that Gradle uses, and repo.maven.apache.org returns 429. Please run ./gradlew test before merging.

Devin-Org: engineering

Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/d29e66c7c62e47249c53c3f920cbc990
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/d29e66c7c62e47249c53c3f920cbc990?variant=devin


Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Custom reviewers

  • 🧪 Test 2 reviewer: no findings · View
  • 🚩 TD Enterprise Architecture: no findings · View
  • 👁️ TD Information Security: no findings · View
  • 🧠 TD French Language (Bill 96): no findings · View
  • ⏱️ TD API Contracts: no findings · View

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants