Repository navigation
test: extra coverage for empty feed pages (PR #1267) - #1268
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
✅ Devin Review: No Issues Found
Devin Review analyzed this PR and found no bugs or issues to report.
Custom reviewers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests for the
fillExtraInfoempty-list guard inArticleQueryServicefrom #1267. Targetsdevin/task-28-feed-empty-page.ArticleQueryServiceUnitTest(new, Mockito): an emptyfindUserFeed/findUserFeedWithCursorpage never callsarticlesFavoriteCount,userFavoritesorfollowingAuthors. Those mappers buildIN (...)from the id list, so an empty list produced invalid SQL and the 500.ArticleQueryServiceTest(DB):count == 0) and empty cursor pagePREVcursor before the first article → empty page,hasPrevious == falseListArticleApiTest:GET /articles/feed?offset=20&limit=20returns 200 witharticles: []andarticlesCountset to the total.Verification gap: the new tests compile (
compileTestJava) and are formatted with google-java-format../gradlew spotlessJavaApply testcould not run in the session: the network policy blocks the Maven mirror that Gradle uses, and repo.maven.apache.org returns 429. Please run./gradlew testbefore merging.Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/d29e66c7c62e47249c53c3f920cbc990
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/d29e66c7c62e47249c53c3f920cbc990?variant=devin