Repository navigation
test: coverage for Boot 3.5 upgrade (#1258) - #1260
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
… handler and jjwt 0.12 JWT service
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Comment on lines
+79
to
+82
| DataFetchingEnvironment env = | ||
| DataFetchingEnvironmentImpl.newDataFetchingEnvironment() | ||
| .executionStepInfo(stepInfo) | ||
| .build(); |
Author
There was a problem hiding this comment.
🔍 Fallback test fails before its assertions
In should_delegate_other_exceptions_to_default_handler, params supplies no merged field, causing a NullPointerException. DGS's DefaultDataFetcherExceptionHandler reads getSourceLocation(), which dereferences that field. The test never reaches its message or error-type assertions.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests for #1258's changed production code. Only test files change; targets #1258's head branch.
Boot3SecurityAndGraphQLIntegrationTest(new; full server on a random port, temp SQLite file)GraphQLHttpConfig:POST /graphqlparses its body whileUNWRAP_ROOT_VALUEis on;POST /usersstill unwraps{"user":{...}}.createUserreturns a JWT thatGET /useraccepts. A failedloginreturnserrorType=UNAUTHENTICATED.SecurityFilterChainover real HTTP:GET /articles/does-not-existreturns 404, not 401 (checks theERROR-dispatchpermitAll)/articles/feed,POST /articlesand an invalid token return 401/tagsand/articlesare public, and the CORS preflight is allowedGraphQLCustomizeExceptionHandlerTest(new): unit tests for the DGS 10handleException. Covers the auth error, the constraint violation (BAD_REQUESTwith field errors in extensions) and fallback to the default handler.DefaultJwtServiceTest(extended for jjwt 0.12):alg:nonetokensWeakKeyExceptionfor secrets under 256 bitsLink to Devin session: https://devin-gtm.devinenterprise.com/sessions/e996ce7a78f5461bb11c349f93da48ee
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/e996ce7a78f5461bb11c349f93da48ee?variant=devin