Repository navigation
test: raise every service to 90%+ line coverage - #1098
Open
devin-ai-integration[bot] wants to merge 32 commits into
Open
devin-ai-integration[bot] wants to merge 32 commits into
devin-ai-integration[bot] wants to merge 32 commits into
Conversation
…ed script, opt-in Postgres tests) Co-Authored-By: derek.wu <derekwu35@gmail.com>
…ine coverage Co-Authored-By: derek.wu <derekwu35@gmail.com>
Co-Authored-By: derek.wu <derekwu35@gmail.com>
Co-Authored-By: derek.wu <derekwu35@gmail.com>
…agerc greenlet tracing Co-Authored-By: derek.wu <derekwu35@gmail.com>
…91% branch Co-Authored-By: derek.wu <derekwu35@gmail.com>
…ith coverage config Co-Authored-By: derek.wu <derekwu35@gmail.com>
Add specs for Incident model/serializer, IncidentsController, ChaosController, ChaosProbeService, HealthChecker, admin HealthController, AdminSettingsService, DevinSessionService HTTP paths, and AlertsController resolve/auth paths. Enable SimpleCov branch coverage. Co-Authored-By: derek.wu <derekwu35@gmail.com>
Co-Authored-By: derek.wu <derekwu35@gmail.com>
Add unit tests for UserService, UserSettingsService, JwtAuthFilter, GlobalExceptionHandler, HealthController degraded paths, refresh/logout paths in AuthService and token-type checks in JwtTokenProvider, plus MockMvc integration tests for settings, logout, user lookup and refresh failures. Add lombok.config so JaCoCo skips Lombok-generated accessors/equals/hashCode. Co-Authored-By: derek.wu <derekwu35@gmail.com>
Co-Authored-By: derek.wu <derekwu35@gmail.com>
…vice' into devin/1795032267-cov90-all
…ice' into devin/1795032267-cov90-all
…ervice' into devin/1795032267-cov90-all
…service' into devin/1795032267-cov90-all
…lling' into devin/1795032267-cov90-all
…rtal' into devin/1795032267-cov90-all
…ion-service' into devin/1795032267-cov90-all
…rvice' into devin/1795032267-cov90-all
…rvice' into devin/1795032267-cov90-all
…ay' into devin/1795032267-cov90-all
…fakes Co-Authored-By: derek.wu <derekwu35@gmail.com>
…, EventProcessor/Health/Config/Main tests Co-Authored-By: derek.wu <derekwu35@gmail.com>
…lock, add coverage runner Co-Authored-By: derek.wu <derekwu35@gmail.com>
Co-Authored-By: derek.wu <derekwu35@gmail.com>
…ice' into devin/1795032267-cov90-all
…-service' into devin/1795032267-cov90-all
Co-Authored-By: derek.wu <derekwu35@gmail.com>
…solutions' into devin/1795032267-cov90-all
…rvice' into devin/1795032267-cov90-all
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…ge run Co-Authored-By: derek.wu <derekwu35@gmail.com>
…for analytics, parity and equivalence jobs Co-Authored-By: derek.wu <derekwu35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raises every service under
services/to at least 90% line coverage. Almost all of the change is new tests. Each service was done in its own subsession and branch (devin/1795032267-cov90-<service>), then merged here. The merges had no conflicts, and each service's tree matches its source branch exactly.PLSQL_OPTIMIZE_LEVEL=2)Non-test changes (coverage tooling, plus one refactor):
legacy-portal/pom.xml,report-service/pom.xmlandnotification-service/build.gradle.kts; scoverage inanalytics-service/project/plugins.sbt;.coveragercin document, search and legacy-billing (document addsconcurrency = greenlet,thread, which fixes the under-reporting);pytest-covinbilling-service/pyproject.toml;auth-service/lombok.configso JaCoCo skips Lombok-generated code;collab-service/jest.config.js;api-gateway/Makefilenow uses-coverpkg=./...;admin-service/spec/spec_helper.rbturns on branch coverage.fail_under = 90), billing (fail_under = 90when run with--cov), collab (jest thresholds: 90 for lines, statements and functions, 85 for branches).analytics-service/build.sbtaddsTest / parallelExecution := false, plus a test resource that pins the Docker API version so the Testcontainers tests run on Docker 29 instead of cancelling silently.configure_routes()insrc/main.rswith no behaviour change, andsrc/events.rsgains a test-only constructor.Tests never assert suspected bugs as correct behaviour; they are marked xfail or skipped, or left unasserted. None of those bugs are fixed here. CI fixes: three jobs were failing on any PR that touches their paths because the runner image changed, not because of these tests.
apt-keywas removed (breaking the analytics-service sbt install), and the default Python moved to 3.14, which has no wheels for asyncpg 0.29 / psycopg-binary 3.2.9 (breakingequivalenceandparity). The fixes: the sbt key now goes into asigned-bykeyring,equivalencepins poetry to Python 3.12, andparitysetsUV_PYTHON=3.12.Coverage wiring in the root
Makefile, extra CI jobs (Postgres/Docker coverage runs) and blueprint changes are deliberately left out of this PR.Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/48b540e5de6d4ac4abdf50815eeca84d
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/48b540e5de6d4ac4abdf50815eeca84d?variant=devin
Requested by: @TheWuster935
🟢 Devin Review found nothing to fix · View findings