Repository navigation
bug: skip expired lots in replenishment autopick - #10
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
✅ Devin Review: No Issues Found
Devin Review analyzed this PR and found no bugs or issues to report.
Custom reviewers
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: Follow-up to #9 (outbound autopick skips expired lots), raised in its review.
Description:
Replenishment autopick has its own copy of the suggestion logic,
PicklistService.getSuggestedItems, and that copy had no expiry check. If a depot held an expired lot with an earlier expiry date, FEFO order put it first, so a replenishment suggested and picked the expired lot.PicklistService.getSuggestedItemsnow drops expired lots from the set autopick can choose from. Only replenishment calls it (ReplenishmentServicesuggested items andPicklistService.createPicklist), so no other flow changes.getAvailableItemsstill returns expired lots, so people can still see and pick them by hand.AvailableItem.isExpired(). A lot expiring today counts as expired, which matchesInventoryItem.expirationStatus. The method is line-for-line the same as the one bug: outbound autopick skips expired lots #9 adds, so the two PRs merge cleanly in either order (checked locally).Tests: the new
PicklistServiceAutopickSpechas 4 cases:All 4 pass on JDK 8. All 4 fail when the
PicklistServicechange is reverted.Frontend CI on
developstill pins Node 14 / npm 6. If that check fails before it runs anything, the cause is the pin, not this change.Devin-Org: engineering
Implemented in session Skip expired lots in openboxes replenishment autopick
Review with Devin · Open in Devin Desktop