Repository navigation
React migration phase 6: PWA service worker and manifest, Angular removal, deploy and docs - #871
Closed
vibhaseshadri-cognition wants to merge 4 commits into
Closed
vibhaseshadri-cognition wants to merge 4 commits into
vibhaseshadri-cognition wants to merge 4 commits into
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…g ngsw-config (migration phase 6) Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
…s (migration phase 6) Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
…ed up (migration phase 6) Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
devin-ai-integration
Bot
force-pushed
the
devin/1791295373-react-phase5-user
branch
from
October 6, 2026 14:54
3c494cd to
6dbadd5
Compare
devin-ai-integration
Bot
force-pushed
the
devin/1791295423-react-phase6-pwa
branch
from
October 6, 2026 14:54
1b5439f to
125d631
Compare
React HN end-to-end UI test (production preview, HEAD 125d631)This covers the whole stack, #867 through #871. It was tested in a browser against the
API caveats
|
|
Closing as part of the nightly demo-repo reset — reopen if this demo artifact is still needed. |
devin-ai-integration
Bot
deleted the
devin/1791295423-react-phase6-pwa
branch
October 26, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last phase of the Angular → React migration: the React app takes over PWA/offline support, the deploy and the docs, and the Angular app is removed. Stacked on Phase 5 (#870).
PWA (
react/vite.config.ts,vite-plugin-pwa+ Workbox), mapped fromngsw-config.json:appgroup,installMode: prefetch(index.html, favicon,*.css,*.js)globPatterns: ['index.html', 'favicon.ico', '**/*.{js,css}']assetsgroup,installMode: lazy,updateMode: prefetch(/assets/**, images/fonts)StaleWhileRevalidatecacheassets, same-origin, same extensionsnavigationUrls→index.htmlnavigateFallback: '/index.html'src/manifest.json→ generatedmanifest.webmanifest(same icons,theme_color #b92b27,display: standalone,orientation: portrait,start_url), name changed to "React HN". Registered withregisterType: 'autoUpdate'and a deferredregisterSW.js, like Angular'sregisterWhenStable.e2e/pwa.spec.ts: checks the manifest is served, waits for the service worker to activate, then goes offline and checks that a reload and client-side navigation still render the shell.Angular removal:
src/,e2e/(Protractor),angular.json,karma.conf.js,ngsw-config.json,tslint.json, the root tsconfigs,browserslist, the rootpackage.jsonandyarn.lock.firebase.jsonnow servesreact/distwith the SPA rewrite, and sendssw.jswithno-cacheso service worker updates reach clients..travis.yml(deploy only) runs Node 20, buildsreact/and deploys to Firebase. Lint, unit tests and e2e run in the GitHub ActionsReact CIworkflow.README.mdandCONTRIBUTING.mdare rewritten for the React app.react/src/setupTests.tsstubswindow.scrollTo, which jsdom doesn't implement. This removes the "Not implemented" noise from the route tests.Not ported: the Universal Analytics snippet (
UA-…). Google has shut down Universal Analytics. Page-view tracking (usePageViews) only fires when agaglobal exists, so a GA4 tag can be added later.Checks run locally on this branch: format, lint, typecheck, 136 unit tests (100% coverage), build, and 35 Playwright tests.
Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/89cdada34e094c0b8a61fae52bf25e08
Open in Devin Desktop: https://app.devin.ai/desktop/session/89cdada34e094c0b8a61fae52bf25e08?variant=devin
Requested by: @vibhaseshadri-cognition