Repository navigation
feature: React migration phase 4 — item details & recursive comments - #868
Closed
vibhaseshadri-cognition wants to merge 1 commit into
Closed
vibhaseshadri-cognition wants to merge 1 commit into
vibhaseshadri-cognition wants to merge 1 commit into
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
devin-ai-integration
Bot
force-pushed
the
devin/1791295336-react-phase4-item-details
branch
from
October 6, 2026 14:10
ac6e740 to
f24934d
Compare
devin-ai-integration
Bot
changed the base branch from
devin/1791294931-react-phase2-shell
to
devin/1791295334-react-phase3-feeds
October 6, 2026 14:10
… tests and e2e (migration phase 4) Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
devin-ai-integration
Bot
force-pushed
the
devin/1791295334-react-phase3-feeds
branch
from
October 6, 2026 14:54
7a2a89a to
52340da
Compare
devin-ai-integration
Bot
force-pushed
the
devin/1791295336-react-phase4-item-details
branch
from
October 6, 2026 14:54
f24934d to
44b2dd9
Compare
|
Closing as part of the nightly demo-repo reset — reopen if this demo artifact is still needed. |
devin-ai-integration
Bot
deleted the
devin/1791295336-react-phase4-item-details
branch
October 26, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
/item/:idplaceholder with a port of Angular'sitem-details+ recursivecommentcomponents (stacked on Phase 2).react/src/item-details/ItemDetails.tsx(+.scss):useParams()id →fetchItemContent(Number(id), signal); aborts on id change/unmount and ignoresAbortError. Loader /ErrorMessage("Could not load item comments.")/ loaded, rootdiv.main-content[data-testid=item-details][data-item-id]rendered in every state.window.scrollTo(0, 0)on mount. Mobile.item-headerwith.back-button→navigate(-1); laptop header withitem-header(comments_count > 0 or job) /head-margin(item.text), external vs internal title link (openLinkInNewTab→target="_blank" rel="noopener"), domain,.subtext,formatCommentCount. Poll.pollContentoptions viaSafeHtml,.pollBarwidthpoints / poll_votes_count * 100%.item.content→SafeHtml as="p" className="subject".react/src/item-details/Comment.tsx(+.scss): recursive; deleted →.deleted-meta; otherwise.meta(+meta-collapse),[-]/[+]toggle,/user/{user}link, time,SafeHtmlcomment-text, nestedul.subtree. Collapsed body uses thehiddenattribute so subtrees stay mounted (Angular[hidden]).ItemDetails.test.tsx,Comment.test.tsx(mocked API module); Playwrighte2e/item-details.spec.tswithe2e/fixtures/item-details.ts(nested tree, deleted comment, poll + poll options, mobile back button, API failure).Parity notes / intentional deviations
role="button",tabIndex=0, Enter/Space (sharedonActivateKey). Toggle hasaria-expandedandaria-label="Collapse|Expand comment by {user}"(visible text still[-]/[+]). Back button hasaria-label="Back".poll_votes_count === 0→ bar width0%(Angular produced an invalidNaN%).hasUrlis null-safe (item.url?.indexOf('http') === 0).item.textisn't in the sharedStorymodel, so it's read through a localStory & { text?: string }type instead of changing shared models..item-view/.comment. Item-detailsulpadding only targets.comment-list(in Angular it never reached the comment subtrees).src/App.test.tsx(which I can't edit) now logs jsdom's "Not implemented: window.scrollTo" when it renders the item route. It's console noise only and tests pass.Coverage (
npm test)Locally passing: format:check, lint, typecheck, test (95 tests), build, e2e (15 tests).
Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/d4b630f04b8f488ea0d9c8f4729aa6e6
Open in Devin Desktop: https://app.devin.ai/desktop/session/d4b630f04b8f488ea0d9c8f4729aa6e6?variant=devin
Requested by: @vibhaseshadri-cognition