Repository navigation
React migration phase 0: Vite + TS scaffold, Vitest/RTL, Playwright, CI - #865
Closed
vibhaseshadri-cognition wants to merge 1 commit into
Closed
vibhaseshadri-cognition wants to merge 1 commit into
vibhaseshadri-cognition wants to merge 1 commit into
Conversation
…ht and CI (migration phase 0) Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This was referenced Oct 6, 2026
|
Closing as part of the nightly demo-repo reset — reopen if this demo artifact is still needed. |
devin-ai-integration
Bot
deleted the
devin/1791294814-react-phase0-scaffold
branch
October 26, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First PR of the Angular → React migration. Adds a standalone React 18 + TypeScript + Vite app under
react/(ownpackage.json/lockfile) so the Angular app in the repo root is untouched until the final phase.tabWidth: 4,singleQuote,printWidth: 120,trailingComma: es5).npm test=vitest run --coveragewith v8 thresholds at 80% for lines/branches/functions/statements (main.tsxand test files excluded).vite build && vite previewon :4173.e2e/support/mock-api.tsexportsmockHnApi(page, handlers)which stubshttps://node-hnapi.herokuapp.com/**so later phases' e2e tests are deterministic..github/workflows/react-ci.yml(push to master + PRs):npm ci→ format check → lint → test+coverage → build, plus a separate Playwright job. Mirrors.travis.yml's build-on-master; Firebase deploy is intentionally left on Travis until the PWA/cleanup phase.src/assets→react/public/assetsfor upcoming phases.The placeholder
App+ one unit test + one smoke e2e exist only so the suites and coverage gate run green; Phase 2 replaces them with the real shell/router.Local verification (
react/):npm run lint,npm run typecheck,npm test(100% coverage),npm run e2e(1 passed).Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/89cdada34e094c0b8a61fae52bf25e08
Open in Devin Desktop: https://app.devin.ai/desktop/session/89cdada34e094c0b8a61fae52bf25e08?variant=devin
Requested by: @vibhaseshadri-cognition