Skip to content

React migration phase 0: Vite + TS scaffold, Vitest/RTL, Playwright, CI - #865

Closed
vibhaseshadri-cognition wants to merge 1 commit into
masterfrom
devin/1791294814-react-phase0-scaffold
Closed

vibhaseshadri-cognition wants to merge 1 commit into
masterfrom
devin/1791294814-react-phase0-scaffold

Conversation

@vibhaseshadri-cognition

@vibhaseshadri-cognition vibhaseshadri-cognition commented Oct 6, 2026 •

Copy link
Copy Markdown

Summary

First PR of the Angular → React migration. Adds a standalone React 18 + TypeScript + Vite app under react/ (own package.json/lockfile) so the Angular app in the repo root is untouched until the final phase.

  • Tooling: ESLint 9 flat config (typescript-eslint, react-hooks, react-refresh, eslint-config-prettier); Prettier config copied from the root (tabWidth: 4, singleQuote, printWidth: 120, trailingComma: es5).
  • Unit tests: Vitest (jsdom, globals) + RTL + jest-dom. npm test = vitest run --coverage with v8 thresholds at 80% for lines/branches/functions/statements (main.tsx and test files excluded).
  • E2E: Playwright, chromium project, runs against vite build && vite preview on :4173. e2e/support/mock-api.ts exports mockHnApi(page, handlers) which stubs https://node-hnapi.herokuapp.com/** so later phases' e2e tests are deterministic.
  • CI: .github/workflows/react-ci.yml (push to master + PRs): npm ci → format check → lint → test+coverage → build, plus a separate Playwright job. Mirrors .travis.yml's build-on-master; Firebase deploy is intentionally left on Travis until the PWA/cleanup phase.
  • Static assets copied from src/assets → react/public/assets for upcoming phases.

The placeholder App + one unit test + one smoke e2e exist only so the suites and coverage gate run green; Phase 2 replaces them with the real shell/router.

Local verification (react/): npm run lint, npm run typecheck, npm test (100% coverage), npm run e2e (1 passed).

Devin-Org: engineering

Link to Devin session: https://app.devin.ai/sessions/89cdada34e094c0b8a61fae52bf25e08
Open in Devin Desktop: https://app.devin.ai/desktop/session/89cdada34e094c0b8a61fae52bf25e08?variant=devin
Requested by: @vibhaseshadri-cognition

…ht and CI (migration phase 0)

Co-Authored-By: Vibha  Seshadri <vibha.seshadri@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown

Closing as part of the nightly demo-repo reset — reopen if this demo artifact is still needed.

@devin-ai-integration
devin-ai-integration Bot deleted the devin/1791294814-react-phase0-scaffold branch October 26, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant