Skip to content

fix: reload profile when the username route param changes - #89

Closed
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/task-25-profile-switch
Closed

devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/task-25-profile-switch

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Summary

Going from another user's profile to your own via the navbar (/profile/sam → /profile/me) changed the URL but kept Sam's header and posts until a reload. Angular reuses ProfileComponent and its child tab components for the same route, and all three read the username once from route.snapshot in ngOnInit.

They now follow the param:

this.route.paramMap.pipe(
  switchMap(params => this.profileService.get(params.get('username')!)),
  ...
)
  • ProfileComponent also clears profile/errors when the username changes.
  • ProfileFavoritesComponent follows route.parent!.paramMap.

Overlap: adds the zone.js ~0.16.0 dev dependency so bun run test -- --run runs on main. #79 and #85 carry the same line, so whichever lands first makes this a no-op.

Checks on this branch: bun run format:check, bun run test -- --run (180/180), bun run build. The CI test/security-tests jobs fail before running any test: ubuntu-latest is now 26.04, and Playwright 1.58 can't install Chromium there. #85 and #79 fail the same way.

Devin-Org: engineering


Migration Engineer opened this PR for Matthew
Implemented in session Wire Angular RealWorld app to Boot 3 backend
Review with Devin · Open in Devin Desktop


@devin-ai-integration

Copy link
Copy Markdown
Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​angular/​core@​21.1.1 ⏵ 21.2.481 -1875 +1579 +198 +1100

View full report

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Custom reviewers

  • 🧪 Test 2 reviewer: no findings · View
  • 🚩 TD Enterprise Architecture: no findings · View
  • 👁️ TD Information Security: no findings · View
  • 🧠 TD French Language (Bill 96): no findings · View
  • ⏱️ TD API Contracts: no findings · View

Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Author

Closing: this fix is now folded into #85 (commit c427cf7), so the Angular side lands as one PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants