Repository navigation
fix: reload profile when the username route param changes - #89
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Author
There was a problem hiding this comment.
✅ Devin Review: No Issues Found
Devin Review analyzed this PR and found no bugs or issues to report.
Custom reviewers
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Going from another user's profile to your own via the navbar (
/profile/sam→/profile/me) changed the URL but kept Sam's header and posts until a reload. Angular reusesProfileComponentand its child tab components for the same route, and all three read the username once fromroute.snapshotinngOnInit.They now follow the param:
ProfileComponentalso clearsprofile/errorswhen the username changes.ProfileFavoritesComponentfollowsroute.parent!.paramMap.Overlap: adds the
zone.js ~0.16.0dev dependency sobun run test -- --runruns onmain. #79 and #85 carry the same line, so whichever lands first makes this a no-op.Checks on this branch:
bun run format:check,bun run test -- --run(180/180),bun run build. The CItest/security-testsjobs fail before running any test:ubuntu-latestis now 26.04, and Playwright 1.58 can't install Chromium there. #85 and #79 fail the same way.Devin-Org: engineering
Implemented in session Wire Angular RealWorld app to Boot 3 backend
Review with Devin · Open in Devin Desktop