Repository navigation
feature: containerize Conduit frontend + docker compose stack (nginx /api proxy, configurable API URL) - #82
Closed
devin-ai-integration[bot] wants to merge 2 commits into
Closed
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
…L, compose stack) and fix vitest harness (zone.js) Co-Authored-By: Parker Duff <pwjduff@gmail.com>
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
Devin Review found 1 potential issue.
2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
…s keep working Co-Authored-By: Parker Duff <pwjduff@gmail.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Containerizes the Conduit Angular frontend and adds the whole-stack
docker-compose.yml. Paired backend PR: COG-GTM/spring-boot-realworld-example-app#1153 (compose builds it from the sibling checkout).https://api.realworld.show/api. It reads anAPI_URLinjection token that defaults toenvironment.apiUrl.environment.tskeeps the public demo API, sobun run startand the e2e suite behave as before.dockerbuild configuration swaps inenvironment.docker.ts(apiUrl: '/api', same-origin).nginxinc/nginx-unprivileged:1.27-alpineruntime (non-root, ~74 MB).docker/nginx.conf.template):/api/foo→rewrite→${BACKEND_URL}/foo, because the backend has no/apiprefix.try_filesfallback.resolver 127.0.0.11with a variableproxy_pass, so a recreated backend container (new IP) doesn't 502.${CONDUIT_PORT:-8080}).wget /tagshealthcheck gating frontend start.conduit-dataat/data/conduit.db.zone.js(devDependency). All 6 specs import it but it wasn't installed, so Vitest loaded 0 files on master.CI
test(Playwright e2e against the publicapi.realworld.show) fails on the same 6settings.spec.tstests (PUT/user→ 422 from the public API) as on #81. It doesn't depend on this change, because the default environment is unchanged.Test results
./gradlew test)bun run test -- --run)zone.jsmissing. Added it + 3API_URLinterceptor testsauth.hurl(8.0.1,host=http://localhost:8080)bio: ""and a placeholderimagewhere the spec expectsnull, andbio/imagecan't be set back tonullarticles.hurlPOST /articlesreturns 200 (spec says 201), and list responses includebody(newer spec leaves it out)docker compose restart→ all persisted. Issues listed belowThe hurl failures come from the Spring backend implementing an older RealWorld spec, not from the container/proxy. Every request (register, login, create, list) goes through nginx
/api→ backend and gets an application response. I didn't change backend semantics to make them pass.Visual issues on screen (pre-existing, not touched in this PR):
https://static.productionready.io/images/smiley-cyrus.jpg(set by the backend) returns 404, so nav, article meta, comments and profile show broken images.scrollWidth 420 > clientWidth 390) on home and article pages, and preview tags touch the dividers.docker compose restartAfter the acceptance run the backend runtime changed (Alpine →
11-jre-jammyfor ARM64, uid/gid pinned to 10001; see backend PR). I re-checked that image withdocker compose up -d --build: the container was recreated on the sameconduit-datavolume, the QA article, comment and favorite were still there, register returned 201, and hurl showed the same failure profile.Run it
Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/64408f2009084eb083deff72f37361bd
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/64408f2009084eb083deff72f37361bd?variant=devin
Requested by: @parkerduff
Note
Devin errored when opening this Pull Request as parkerduff.
As a fallback, Devin opened this PR as itself.
Devin Review