Skip to content

[Java 25] Docker image: Maven + Temurin 25 build, temurin:25-jre-alpine runtime - #391

Merged
devin-ai-integration[bot] merged 1 commit into
devin/java25-springboot-bankappfrom
devin/java25-containers
Nov 19, 2026
Merged

devin-ai-integration[bot] merged 1 commit into
devin/java25-springboot-bankappfrom
devin/java25-containers

Conversation

@shayanshafii

@shayanshafii shayanshafii commented Nov 19, 2026 •

Copy link
Copy Markdown

Summary

Moves the Dockerfile onto Java 25 so the container image matches the Java 25 / Spring Boot 4.1.2 integration branch. This change touches only the Dockerfile and does not change app behavior.

-FROM maven:3.8.3-openjdk-17 as builder
-MAINTAINER Madhup Pandey<madhuppandey2908@gmail.com>
+FROM maven:3.9-eclipse-temurin-25 AS builder
+LABEL maintainer="Madhup Pandey <madhuppandey2908@gmail.com>"
 ...
-FROM eclipse-temurin:17-jre-alpine as deployer
+FROM eclipse-temurin:25-jre-alpine AS deployer

The runtime image now reports OpenJDK 25.0.5 Temurin-25.0.5+8 LTS. Busybox wget is still at /usr/bin/wget, so the e2e health probe keeps working. docker-compose.yml and e2e/docker-compose.e2e.yml needed no changes.

Verification (JDK 25, rebased on 974f460 dialect fix)

Check Before (Java 17 image) After
docker build ok ok
./mvnw clean test (JDK 25) n/a pass
Cypress e2e smoke (stack:up → stack:seed → cy:run) 13/13 13/13 passing, 0 failing, 5/5 specs

Cypress specs: 01-register 3/3, 02-login 3/3, 03-transactions 1/1, 04-transfer 3/3, 05-deposit-withdrawal 3/3.

How I verified locally: this VM's egress IP gets HTTP 429 from repo.maven.apache.org. To work around it, I built from a throwaway copy of this Dockerfile with one extra line, COPY --from=m2 settings.xml /root/.m2/settings.xml, which points Maven at the Google Maven Central mirror. Nothing else in the build differed. I then ran the stack with E2E_SKIP_BUILD=1. CI builds the committed Dockerfile unchanged.

Not changed in this PR: the healthcheck in root docker-compose.yml still runs curl against /actuator/health. That was already broken before this PR, because the alpine image has no curl and the app has no actuator. The e2e override replaces it with a wget probe of /login.

Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/d0750424ed984c19b3df1137bc1ac0f1
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/d0750424ed984c19b3df1137bc1ac0f1?variant=devin
Requested by: @shayanshafii


Devin Review

@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration
devin-ai-integration Bot merged commit e6e2cd4 into devin/java25-springboot-bankapp Nov 19, 2026
6 of 8 checks passed

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Custom reviewers

  • ✨ Blast Radius Reviewer: no findings · View
  • 🛡️ API Security Reviewer: no findings · View
  • 🔒 Sparta Review Guardrails (from top PR comments): no findings · View

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant