Repository navigation
[Java 25] Docker image: Maven + Temurin 25 build, temurin:25-jre-alpine runtime - #391
Merged
devin-ai-integration[bot] merged 1 commit intoNov 19, 2026
Conversation
Co-Authored-By: shayan <shayan@cognition.ai>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
devin-ai-integration
Bot
merged commit Nov 19, 2026
e6e2cd4
into
devin/java25-springboot-bankapp
6 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the
Dockerfileonto Java 25 so the container image matches the Java 25 / Spring Boot 4.1.2 integration branch. This change touches only the Dockerfile and does not change app behavior.The runtime image now reports
OpenJDK 25.0.5 Temurin-25.0.5+8 LTS. Busyboxwgetis still at/usr/bin/wget, so the e2e health probe keeps working.docker-compose.ymlande2e/docker-compose.e2e.ymlneeded no changes.Verification (JDK 25, rebased on 974f460 dialect fix)
docker build./mvnw clean test(JDK 25)stack:up→stack:seed→cy:run)Cypress specs: 01-register 3/3, 02-login 3/3, 03-transactions 1/1, 04-transfer 3/3, 05-deposit-withdrawal 3/3.
How I verified locally: this VM's egress IP gets HTTP 429 from
repo.maven.apache.org. To work around it, I built from a throwaway copy of this Dockerfile with one extra line,COPY --from=m2 settings.xml /root/.m2/settings.xml, which points Maven at the Google Maven Central mirror. Nothing else in the build differed. I then ran the stack withE2E_SKIP_BUILD=1. CI builds the committed Dockerfile unchanged.Not changed in this PR: the healthcheck in root
docker-compose.ymlstill runscurlagainst/actuator/health. That was already broken before this PR, because the alpine image has no curl and the app has no actuator. The e2e override replaces it with awgetprobe of/login.Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/d0750424ed984c19b3df1137bc1ac0f1
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/d0750424ed984c19b3df1137bc1ac0f1?variant=devin
Requested by: @shayanshafii