Skip to content

[Java 25] Modernize persistence layer (entities, datasource config) - #390

Merged
devin-ai-integration[bot] merged 1 commit into
devin/java25-springboot-bankappfrom
devin/java25-persistence
Nov 19, 2026
Merged

devin-ai-integration[bot] merged 1 commit into
devin/java25-springboot-bankappfrom
devin/java25-persistence

Conversation

@shayanshafii

@shayanshafii shayanshafii commented Nov 19, 2026 •

Copy link
Copy Markdown

Summary

Persistence-layer cleanup on top of the Java 25 / Spring Boot 4.1.2 integration branch. No schema, API or behavior changes; public constructors/getters/setters untouched.

  • Account / Transaction: explicit jakarta.persistence imports instead of *; Account (a UserDetails, hence Serializable) gets @Serial private static final long serialVersionUID = 1L.
  • application.properties: useSSL=false → sslMode=DISABLED (Connector/J's replacement for the deprecated useSSL; same effect). The removed MySQL8Dialect was already dropped on the base branch (974f460) — Hibernate 7 auto-detects MySQLDialect.
  • Repositories: no change needed (derived queries findByUsername / findByAccountId work as-is on Spring Data 4).
  • Not done on purpose: no equals/hashCode added to entities (would change identity semantics), open-in-view left at default (disabling it could break lazy loading in views).

Parity

Check Baseline (DevOps, Java 17 / Boot 3.3.3) This PR (Java 25 / Boot 4.1.2 / Hibernate 7.4)
./mvnw clean test — 1 run, 1 passed
spring-boot:run vs MySQL 8.0 starts starts, /login & /register 200
Generated DDL (account, transaction, FK) baseline identical (SHOW CREATE TABLE diff empty)
Mismatches none

Schema checked by running each branch against a freshly created bankappdb on mysql:8.0 (ddl-auto=update) and diffing SHOW CREATE TABLE output, including FK name FK6g20fcr3bhr6bihgy24rq1r1b.

Devin-Org: engineering

Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/908161afbe3f463096d0820f3d1932b0
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/908161afbe3f463096d0820f3d1932b0?variant=devin
Requested by: @shayanshafii


Devin Review

Co-Authored-By: shayan <shayan@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration
devin-ai-integration Bot merged commit 1de22a1 into devin/java25-springboot-bankapp Nov 19, 2026
5 of 8 checks passed

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Custom reviewers

  • ✨ Blast Radius Reviewer: no findings · View
  • 🛡️ API Security Reviewer: no findings · View
  • 🔒 Sparta Review Guardrails (from top PR comments): no findings · View

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant