Skip to content

[Java 25] Build tooling & CI: Maven 3.9.16 wrapper, enforcer, GitHub Actions build - #387

Merged
devin-ai-integration[bot] merged 1 commit into
devin/java25-springboot-bankappfrom
devin/java25-build-ci
Nov 19, 2026
Merged

devin-ai-integration[bot] merged 1 commit into
devin/java25-springboot-bankappfrom
devin/java25-build-ci

Conversation

@shayanshafii

@shayanshafii shayanshafii commented Nov 19, 2026 •

Copy link
Copy Markdown

Summary

Build/CI slice of the Java 25 upgrade (targets the integration branch devin/java25-springboot-bankapp).

  • Maven wrapper: regenerated with maven-wrapper-plugin:3.3.4:wrapper -Dmaven=3.9.16 -Dtype=only-script → wrapper 3.3.4, Maven 3.9.16 (latest 3.9.x). mvnw/mvnw.cmd are the stock generated scripts.
  • pom.xml <build><plugins> only: added maven-enforcer-plugin (version managed by Spring Boot parent, resolves to 3.6.3) with requireJavaVersion [25,) and requireMavenVersion [3.9,). Dependencies/properties/parent untouched.
  • New .github/workflows/build.yml: ./mvnw -B clean verify on Temurin 25 with Maven cache, on push to DevOps and on pull_request. e2e.yml untouched.
  • Jenkins (Jenkinsfile, GitOps/Jenkinsfile, vars/*.groovy): no Java/JDK version references exist (Sonar/OWASP use named tool installations only), so no changes needed.

Verification

Before After
Maven 3.9.7 3.9.16
./mvnw clean test on JDK 25 1 run / 1 passed 1 run / 1 passed, BUILD SUCCESS
./mvnw clean verify on JDK 25 n/a enforcer rules passed, BUILD SUCCESS
./mvnw validate on JDK 21 passes fails fast: "JDK ... version 21 ... not in the allowed range [25,)" (intended)

No functional/application changes; no endpoints affected.

Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/78dcaa087d74417ea914c881e2088023
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/78dcaa087d74417ea914c881e2088023?variant=devin
Requested by: @shayanshafii


Devin Review

…ons build

Co-Authored-By: shayan <shayan@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Custom reviewers

  • ✨ Blast Radius Reviewer: no findings · View
  • 🛡️ API Security Reviewer: no findings · View
  • 🔒 Sparta Review Guardrails (from top PR comments): no findings · View

Devin Review

Comment thread mvnw.cmd
if ((Get-Item $MAVEN_M2_PATH).Target[0] -eq $null) {
$MAVEN_WRAPPER_DISTS = "$MAVEN_M2_PATH/wrapper/dists"
} else {
$MAVEN_WRAPPER_DISTS = (Get-Item $MAVEN_M2_PATH).Target[0] + "/wrapper/dists"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Relative Maven cache links resolve incorrectly

With a relative symbolic link for .m2, $MAVEN_WRAPPER_DISTS resolves against the project directory instead of the link’s parent. Existing Maven installations are missed, and offline builds fail even when the linked cache contains Maven.

Learn more

Windows symbolic links can store relative targets. The Target property exposes that stored target, which must be interpreted relative to the directory containing the link. Concatenating it directly with /wrapper/dists leaves a relative path that subsequent filesystem operations interpret from the build's working directory. The previous implementation retained the .m2 path and let Windows follow the link correctly. This also affects symbolic links supplied through MAVEN_USER_HOME.

Example: A developer creates C:\Users\Alice\.m2 pointing to the relative target maven-cache, with Maven already installed under C:\Users\Alice\maven-cache\wrapper\dists. Running the wrapper from C:\work\bankapp instead looks under C:\work\bankapp\maven-cache\wrapper\dists and attempts another download. Without network access, that build fails despite the existing installation.

Recommended fix: Resolve relative targets against the parent directory of $MAVEN_M2_PATH before constructing $MAVEN_WRAPPER_DISTS, while preserving absolute targets. Alternatively, retain the original Maven user directory path and let filesystem operations traverse its symbolic link. Validate both relative and absolute directory links on Windows PowerShell.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integration
devin-ai-integration Bot merged commit 584bea7 into devin/java25-springboot-bankapp Nov 19, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant