Repository navigation
Redraw CI/CD flow diagram and add EKS deployment diagram - #379
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
…m with Graphviz sources Co-Authored-By: taylor.curran <taylorcurranagtc@gmail.com>
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
✅ Devin Review: No Issues Found
Devin Review analyzed this PR and found no bugs or issues to report.
Custom reviewers
Co-Authored-By: taylor.curran <taylorcurranagtc@gmail.com>
Author
|
Rendered-docs check (local GFM preview, no GitHub login)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
images/flow.png(embedded incicd.md) still showed the old setup: Jenkins building one image and deploying with docker compose onto a single EC2 box. OnDevOpsthe app goes through the full Jenkins CI pipeline, a GitOps CD job and ArgoCD onto EKS, andREADME.md/README-K8S.mddescribed that EKS + ArgoCD + Prometheus/Grafana stack with no diagram at all.images/flow.pngwith the current CI/CD flow, drawn fromJenkinsfileandGitOps/Jenkinsfile: BankApp-CI stages (Trivy, OWASP, SonarQube + quality gate, Docker build, Cypress E2E, push), the hand-off to BankApp-CD withDOCKER_TAG, the manifest commit, and ArgoCD syncingkubernetes/to EKS. The GitHub Actionse2e.ymlsmoke run is shown as a side path.images/eks-deployment.png: the Master EC2 machine (Jenkins :8081, SonarQube :9000, CLIs) and thebankappEKS cluster with its namespaces: ingress-nginx + cert-manager,argocd,bankapp-namespace(Ingress →bankapp-service→bankapp-deploy+ HPA →mysql-svc→ MySQL + PVC), andprometheus(kube-prometheus-stack).docs/diagrams/*.dot(Graphviz). Rundocs/diagrams/render.shto re-render both PNGs.cicd.md's workflow bullets now describe the CI → CD → ArgoCD path.README.mdandREADME-K8S.mdeach get an Architecture section that embeds both diagrams.Before
After: CI/CD flow (
images/flow.png)New: EKS deployment (
images/eks-deployment.png)Mismatches found in the repo (drawn as intended, not changed here)
madhupdevops/bankapp:<tag>, but the CDsedrewritestrainwithshubham/bankapp-eks:<tag>inbankapp-deployment.yaml. The file is actuallykubernetes/bankapp-deployment.yml, so as written the tag update step would not match anything.README.mdsays to open the app on<worker-ip>:30080, butkubernetes/bankapp-service.yamlis a ClusterIP service exposed throughbankapp-ingress(port 30080 comes from thehelm/bankappchart). The diagram follows thekubernetes/manifests that ArgoCD syncs.Devin-Org: engineering
Implemented in session Redraw Springboot-BankApp CI/CD and EKS diagrams
Review with Devin · Open in Devin Desktop
Note
Devin errored when opening this Pull Request as taylorcurranpython.
As a fallback, Devin opened this PR as itself.