Skip to content

Redraw CI/CD flow diagram and add EKS deployment diagram - #379

Open
devin-ai-integration[bot] wants to merge 2 commits into
DevOpsfrom
devin/task-5-redraw-cicd-eks-diagrams
Open

devin-ai-integration[bot] wants to merge 2 commits into
DevOpsfrom
devin/task-5-redraw-cicd-eks-diagrams

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Summary

images/flow.png (embedded in cicd.md) still showed the old setup: Jenkins building one image and deploying with docker compose onto a single EC2 box. On DevOps the app goes through the full Jenkins CI pipeline, a GitOps CD job and ArgoCD onto EKS, and README.md / README-K8S.md described that EKS + ArgoCD + Prometheus/Grafana stack with no diagram at all.

  • Replaced images/flow.png with the current CI/CD flow, drawn from Jenkinsfile and GitOps/Jenkinsfile: BankApp-CI stages (Trivy, OWASP, SonarQube + quality gate, Docker build, Cypress E2E, push), the hand-off to BankApp-CD with DOCKER_TAG, the manifest commit, and ArgoCD syncing kubernetes/ to EKS. The GitHub Actions e2e.yml smoke run is shown as a side path.
  • Added images/eks-deployment.png: the Master EC2 machine (Jenkins :8081, SonarQube :9000, CLIs) and the bankapp EKS cluster with its namespaces: ingress-nginx + cert-manager, argocd, bankapp-namespace (Ingress → bankapp-service → bankapp-deploy + HPA → mysql-svc → MySQL + PVC), and prometheus (kube-prometheus-stack).
  • Editable sources are under docs/diagrams/*.dot (Graphviz). Run docs/diagrams/render.sh to re-render both PNGs.
  • cicd.md's workflow bullets now describe the CI → CD → ArgoCD path. README.md and README-K8S.md each get an Architecture section that embeds both diagrams.

Before

Old flow diagram

After: CI/CD flow (images/flow.png)

CI/CD flow

New: EKS deployment (images/eks-deployment.png)

EKS deployment

Mismatches found in the repo (drawn as intended, not changed here)

  • CI pushes madhupdevops/bankapp:<tag>, but the CD sed rewrites trainwithshubham/bankapp-eks:<tag> in bankapp-deployment.yaml. The file is actually kubernetes/bankapp-deployment.yml, so as written the tag update step would not match anything.
  • README.md says to open the app on <worker-ip>:30080, but kubernetes/bankapp-service.yaml is a ClusterIP service exposed through bankapp-ingress (port 30080 comes from the helm/bankapp chart). The diagram follows the kubernetes/ manifests that ArgoCD syncs.

Devin-Org: engineering


Technical Writer opened this PR for Taylor
Implemented in session Redraw Springboot-BankApp CI/CD and EKS diagrams
Review with Devin · Open in Devin Desktop



Note

Devin errored when opening this Pull Request as taylorcurranpython.
As a fallback, Devin opened this PR as itself.

…m with Graphviz sources

Co-Authored-By: taylor.curran <taylorcurranagtc@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Custom reviewers

  • 🧪 Test 2 reviewer: no findings · View
  • 🚩 TD Enterprise Architecture: no findings · View
  • 👁️ TD Information Security: no findings · View
  • 🧠 TD French Language (Bill 96): no findings · View
  • ⏱️ TD API Contracts: no findings · View

Devin Review

Co-Authored-By: taylor.curran <taylorcurranagtc@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Author

Rendered-docs check (local GFM preview, no GitHub login)

  • README.md and README-K8S.md render both diagrams. cicd.md embeds the CI/CD diagram and links the EKS one.
  • Every relative link resolves (Jenkinsfiles, docs/diagrams/*, images/*.png).
  • ./docs/diagrams/render.sh reproduces the committed PNGs byte-for-byte, and the working tree stays clean.
  • I spot-checked the diagram content against Jenkinsfile, GitOps/Jenkinsfile and kubernetes/*: stage order, namespaces, services, and HPA 1–5 @ 40% CPU all match.
  • The run flagged small labels at 100% zoom. I enlarged the fonts in 2ce2477, so the screenshots below show the earlier, smaller-font render.
CI/CD in cicd.md EKS in README-K8S.md
CI/CD preview EKS preview

Test recording

Written by Devin

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants