Repository navigation
Upgrade to Java 21 - #378
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- pom.xml: java.version 21; drop maven-compiler-plugin override pinning source/target 1.8 - Dockerfile: maven:3.9-eclipse-temurin-21 builder, eclipse-temurin:21-jre-alpine runtime - README/README-K8S: Jenkins host JRE openjdk-21-jre Co-Authored-By: Joao Esteves <joao.esteves@cognition.ai>
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
✅ Devin Review: No Issues Found
Devin Review analyzed this PR and found no bugs or issues to report.
Custom reviewers
- 🧪 Test 2 reviewer: no findings · View
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves build and runtime from Java 17 to Java 21 (LTS). Spring Boot 3.3.3 already supports 21, so no code or dependency changes were needed.
pom.xml:java.version17 → 21. Removed themaven-compiler-plugin3.8.0 block that pinnedsource/targetto1.8. The Spring Boot parent's managed compiler plugin now compiles with--release ${java.version}. No other plugin or dependency pins a Java version.Dockerfile: buildermaven:3.8.3-openjdk-17→maven:3.9-eclipse-temurin-21, runtimeeclipse-temurin:17-jre-alpine→eclipse-temurin:21-jre-alpine.README.md/README-K8S.md: the Jenkins host install now usesopenjdk-21-jre. Jenkins supports Java 21.Jenkinsfile,vars/,GitOps/,helm/,kubernetes/or.github/. The pipeline builds through the Dockerfile, and the manifests only reference image tags.Verification (local, JDK 21.0.13)
./mvnw clean verify: BUILD SUCCESS,Tests run: 1, Failures: 0, Errors: 0.docker buildsucceeds.java -versioninside the image reports Temurin 21.0.13.Note: Maven Central (
repo.maven.apache.org) was returning HTTP 429 on the VM. Local builds used a Google Maven Central mirror through~/.m2/settings.xml. That setting is local only; this PR does not include any repo changes for it.Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/bda99ea2eda14e8a9fb988e26e869f31
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/bda99ea2eda14e8a9fb988e26e869f31?variant=devin
Requested by: @joao-cognition
Note
Devin errored when opening this Pull Request as joao-cognition.
As a fallback, Devin opened this PR as itself.
🟢 Devin Review found nothing to fix · View findings