perf: eliminate GC pressure in touch/pointer handlers#32
Open
Avatarsia wants to merge 2 commits intoCNCKitchen:mainfrom
Open
perf: eliminate GC pressure in touch/pointer handlers#32Avatarsia wants to merge 2 commits intoCNCKitchen:mainfrom
Avatarsia wants to merge 2 commits intoCNCKitchen:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… camera utils Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plane,Rayx2,Vector3x2,Vector2x2) to replace per-eventnewcalls in touch/pointer handlers_lastPointerand_pinchMidobjects instead of creating new{ x, y }literals on every eventscene.background.set()instead ofnew THREE.Color()in theme switching_tmpSize/_tmpV5infitCameraandsetProjectionImpact: Eliminates ~360 heap allocations/second during touch drag (pinch-zoom, pan, orbit) on mobile devices. Zero allocations in hot-path event handlers after this change.
Test plan
node --check js/viewer.jspasses🤖 Generated with Claude Code