Fix/make scripts compatible with system python - #13
Open
sadegh-majidi wants to merge 2 commits into
Open
sadegh-majidi wants to merge 2 commits into
sadegh-majidi wants to merge 2 commits into
Conversation
… to prevent alocal error and make scons build script compatible with python3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The python scripts in this project were primarily written in python2. As most systems use python3 by default nowadays, I changed the python scripts in this project to make them compatible with versions 2 and 3 of python. I also added the "lrztar" installation script to setup.h file for ease of use. As git does not preserve the file's timestamps, we face a problem with "aclocal" during the simulator compilation when we clone the code from the repository instead of using zip format. To overcome this problem, I changed the compilation scripts and did an "autoreconf" before compiling. There was a problem with including the "cstdint" library in the locality.h source file, which caused an error during compilation. This library contains standard integer types for c++ language. I also fixed this include-related error in this pull request.