Skip to content

Issues with new GLS method #124

Description

@degitz

There are problems regarding implementation of the generalized least squares (GLS) method for channel combination.

In op_getcoilcombos, averages must not be combined in order to use the GLS method. There should be a check added in the beginning to verify the input data has an averages dimension to avoid getting an error.

In op_addrcvrs, using the GLS method requires four inputs to the function. This is inconsistent with the other methods, all of which calculate the coil phases and amplitudes within the function if less than four inputs are provided. If you attempt to use the GLS method with less than four inputs, however, the output twix.fids and twix.specs will be arrays of zeros.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions