Skip to content

PMP: Corefinement polish documentation - #9485

Closed
afabri wants to merge 1 commit into
CGAL:mainfrom
afabri:PMP-corefine_wording-GF
Closed

afabri wants to merge 1 commit into
CGAL:mainfrom
afabri:PMP-corefine_wording-GF

Conversation

@afabri

@afabri afabri commented May 20, 2026 •

Copy link
Copy Markdown
Member

Summary of Changes

Taken the importance of autorefinement the documentation should be improved.

Todo

  • typos
  • Add example in the User Manual.
  • Add an illustration
  • @LeoValque told me that the comment of the function is not correct. He mentioned a partial overlap of two triangle edges.

Release Management

  • Affected package(s): PMP_Boolean
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership: unchanged

@afabri

afabri commented May 21, 2026

Copy link
Copy Markdown
Member Author

@sloriot @LeoValque it would be great if you added something like this as image and example:
image

@sloriot

sloriot commented Jun 2, 2026

Copy link
Copy Markdown
Member

Successfully tested in CGAL-6.2-Ic-190

@afabri

afabri commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

I do not understand the sentence " If several triangles are coplanar, the output will contain as many copies of the triangulation of those refined triangles." in the User Manual

@sloriot

sloriot commented Jul 22, 2026

Copy link
Copy Markdown
Member

I do not understand the sentence " If several triangles are coplanar, the output will contain as many copies of the triangulation of those refined triangles." in the User Manual

You are computing the intersection of the input triangles and retriangulate those triangles. If you have 3 overlapping triangles (coplanar then), you will get 3 times the triangles in the overlapping zone.

@sloriot

sloriot commented Aug 11, 2026

Copy link
Copy Markdown
Member

Included in #9363

@sloriot sloriot closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants