Repository navigation
Conversation
+ cosmetic changes about debug message, or "typedefs"
- do not try to support C++20 modules (to speed up compilations) - factorize the uses of `std::chrono::*` in dedicated functions with shorter names - add a namespace in the `.cpp` file, to avoid conflicts with any C-header (in my case it was the identifier `clock`, defined as a function by `<time.h>`)
(`n` is the number of constrained edges)
…_only_in_volume-GF
split `dump_link_mesh_of_vertex_to_ply` into 3 functions
- `collect_star_components_facets`` returns more information - and it is called with an incident constrained facet of `v`
Now the debug outputs about moving Steiner vertices are correctly protected and indented.
…_only_in_volume-GF
janetournois
force-pushed
the
CDT_3-Steiner_points_only_in_volume-GF
branch
from
October 8, 2026 15:07
9077762 to
612eda6
Compare
…T_3-Steiner_points_only_in_volume-GF
…T_3-Steiner_points_only_in_volume-GF
```
[build] .../include/CGAL/tetrahedral_remeshing.h:576:7: error: non-constant-expression cannot be narrowed from type 'int' to 'std::size_t' (aka 'unsigned long') in initializer list [-Wc++11-narrowing]
[build] 576 | choose_parameter(get_parameter(np, internal_np::nb_smoothing_iterations), std::size_t{1}),
[build] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
# Conflicts: # Tetrahedral_remeshing/include/CGAL/Tetrahedral_remeshing/internal/collapse_short_edges.h
…ts_only_in_volume-GF' into CDT_3-Steiner_points_only_in_volume-GF
…on-GF' into CDT_3-Steiner_points_only_in_volume-GF # Conflicts: # Triangulation_2/include/CGAL/Triangulation_2.h
… copy- and move-constructors
…on-GF' into CDT_3-Steiner_points_only_in_volume-GF
…on-GF' into CDT_3-Steiner_points_only_in_volume-GF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This is a work in progress. To be fiilled...
Release Management