Improve Mesh_3 memory footprint by MaelRL · Pull Request #9331 · CGAL/cgal

MaelRL · 2026-02-17T13:25:57Z

heaptrack | vtune | usr/bin/time

mesh vertex base: number_of_incident_facets_ and number_of_components_ to int (or even smaller)?
get rid of sliver_value and use a local unordered_map<Cell_handle, sliver_value> in the optimizers?
get rid of subdomain index? ==> could be interesting because not all cells are in the domain, due to alignment, we gain nothing at the moment
canonical facets in the C3T3 map (more complex than it seems: the canonical facet could be in the conflict zone, but the information shouldn't be lost when it's removed from the complex, before the creation of a new facet)
can gain a little bit with writing a compact_mesh_vertex_3: there is a for example a Boolean in the TDS vertex base
Reduce the size of Point_3*? In sequential it's straightforward (e.g. quietNaN), but concurrent? But it's only stored for cells in complex, so is it worth it (3 doubles always vs 1 always and 1+3 often)
MISC: Can have memory leaks in parallel if multiple new circumcenters at the same time?

TODO:

Announce breaking change on criteria template parameter
Fix binary I/O (SMDS_3 - C3T3 I/O #9376)

The point is that in cell bases, we store facet info at great memory cost given that only a small fraction of the facets are surface (i.e., part of the complex / restricted) facets.

WIP: available with both cell member API and map API

- Get rid of the caches: squat the value -2 - Re-order class member to use as few bytes as possible

I need access to the C3T3 member functions. This could be restricted to surface facet criteria only, but might as well do it for everything.

- Do not use a base_base - Avoid the sliver cache: all values are positive, so squat -2 as a cache. - Do not use surface info arrays, use the C3T3 maps - Re-order for byte padding

# Conflicts: # .github/workflows/checks.yml

I have added a test as well.

For the moment, Tetrahedral Remeshing does not compile. Disable the test.

…ntation

lrineau · 2026-10-09T13:39:26Z

/build:doc

github-actions · 2026-10-09T13:44:12Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9331/doc/Manual/index.html

afabri added the Pkg::Mesh_3 label Feb 17, 2026

MaelRL added 11 commits February 18, 2026 13:11

Do not duplicate C3T3 in write_MEDIT

2cf9156

Introduce a map that stores surface facet info

2e53b28

The point is that in cell bases, we store facet info at great memory cost given that only a small fraction of the facets are surface (i.e., part of the complex / restricted) facets.

Add C3T3 member function to access all surface facet info

c6c22fe

WIP: available with both cell member API and map API

TEMP: Fix Refine_cells_3 not unmarking facets about to be destroyed

8a062ad

Optimize Mesh_vertex_base_3's memory footprint:

0484803

- Get rid of the caches: squat the value -2 - Re-order class member to use as few bytes as possible

Use the generic C3T3 member functions to access facet surface info

a88a4d9

Template mesh criteria by the C3T3 and not the triangulation

a1f9533

I need access to the C3T3 member functions. This could be restricted to surface facet criteria only, but might as well do it for everything.

WIP: Optimize Compact_mesh_cell_base_3:

4e6dd17

- Do not use a base_base - Avoid the sliver cache: all values are positive, so squat -2 as a cache. - Do not use surface info arrays, use the C3T3 maps - Re-order for byte padding

TMP: disable some code

a35a048

TMP: Surface checks for both API

e0f60f6

TMP: dump map size

c77a5b8

MaelRL force-pushed the Mesh_3-memory-culling-GF branch from 7532b99 to 38626ba Compare February 18, 2026 12:15

MaelRL added 5 commits February 18, 2026 17:36

Fix index type

0f831f7

Fix missing typedef

259bde3

Erase no-longer-surface facets from the C3T3 surface info map

6f4a1b1

Avoid copies of shared data parameters

8c6dd57

Add move constructions to Polyhedral_mesh_domain_with_features

b5357bf

MaelRL force-pushed the Mesh_3-memory-culling-GF branch from 1bd040f to b5357bf Compare February 18, 2026 16:39

MaelRL added 11 commits February 18, 2026 17:48

Deal with warnings

565fde0

Back to using compact_base_bases, but with good padding

d3b9bfa

Fix macro choice

898a78f

Parallel Facet->Surface info map + factorize/fix Edge Facet counter

16c34b9

Avoid some map look ups

6237d67

Avoid some cell -> facet -> cell conversions

6e9beb2

Fix documentation of internal function

6e90c4e

Misc tiny fixes

df32131

Avoid some copies

84868dc

Template criteria by the C3t3

aaad872

EqualityComparable gives only operator==

a941c55

afabri reviewed Oct 2, 2026

View reviewed changes

Comment thread SMDS_3/include/CGAL/Mesh_complex_3_in_triangulation_3.h Outdated

afabri reviewed Oct 2, 2026

View reviewed changes

Comment thread SMDS_3/include/CGAL/Mesh_complex_3_in_triangulation_3.h Outdated

afabri reviewed Oct 2, 2026

View reviewed changes

Comment thread SMDS_3/include/CGAL/SMDS_3/tet_soup_to_c3t3.h

lrineau and others added 10 commits October 2, 2026 08:56

fix errors from testsuite

dfa804e

Merge remote-tracking branch 'cgal/main' into pr/MaelRL/9331-2

812de1f

# Conflicts: # .github/workflows/checks.yml

Merge branch 'Scripts-improve_CI-lrineau' into pr/MaelRL/9331-2

69e4804

Merge remote-tracking branch 'cgal/main' into Mesh_3-memory-culling-GF

90ee1c6

fix unused type warning

730f8c4

remove erroneous include

693122d

workaround for MSVC

29d9624

fix tet remeshing when patch info is not in cells

eb80c60

I have added a test as well.

improve the internal named parameters API

bfa06f6

WIP for tet remeshing with a C3t3 that stores facet info in hash map

9935e29

For the moment, Tetrahedral Remeshing does not compile. Disable the test.

sloriot removed the Under Testing label Oct 6, 2026

MaelRL modified the milestones: 6.3-beta, 6.4-beta Oct 7, 2026

lrineau added 3 commits October 7, 2026 10:05

fix NP::has_parameter

385e84b

test the backward compatibility

d36b47c

revert the WIP about tet remeshing and named parameters

570c2a4

janetournois mentioned this pull request Oct 8, 2026

Tetrahedral remeshing - make it work with lightweight C3t3 #9712

Open

MaelRL modified the milestones: 6.4-beta, 6.3-beta Oct 8, 2026

announcement the breaking change for mesh criteria and fix the docume…

761cfc4

…ntation

lrineau removed Not yet approved The feature or pull-request has not yet been approved. TODO CHANGES.md not updated labels Oct 9, 2026

fix links

44a80fb

sloriot added the Under Testing label Oct 14, 2026

Navigation Menu

Repository navigation

Improve Mesh_3 memory footprint - #9331

Improve Mesh_3 memory footprint#9331
MaelRL wants to merge 129 commits into
CGAL:mainfrom
MaelRL:Mesh_3-memory-culling-GF

MaelRL commented Feb 17, 2026 •

edited by lrineau

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lrineau commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

MaelRL commented Feb 17, 2026 • edited by lrineau Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lrineau commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MaelRL commented Feb 17, 2026 •

edited by lrineau

Loading