Repository navigation
Mark variables declared at global scope in headers as 'inline'. - #8874
Merged
Merged
Conversation
MaelRL
added
Bug
named parameters
Not yet approved
lrineau
approved these changes
May 6, 2025
lrineau
added
Ready to be tested
and removed
Not yet approved
Member
|
Successfully tested in CGAL-6.1-Ic-155 note that constexpr are added by #7966 |
5 tasks
efifogel
pushed a commit
to efifogel/cgal
that referenced
this pull request
Jan 14, 2026
…#8874) ## Summary of Changes `const` variables declared at global scope have internal linkage, and so if they are declared in a header file, they are replicated in every file that `#include` the header. They also can't be the target of `using` declarations that exports the variable into a C++20 module. This change marks a number of variables with `inline`, which gives these variables external linkage, allows the linker to unify all of these variables between different `.o` files, and also allows for their use in C++20 modules. There is a separate question whether these variables could or should be `constexpr` instead of just `const`. The difference between `constexpr` and `const` has no effect on linkage, and so in the spirit of taking one step at a time, this patch does not address the `constexpr` vs `const` question. This patch fixes CGAL#8871. Related to dealii/dealii#18071. ## Release Management * Affected package(s): 5.6.1 * Issue(s) solved (if any): CGAL#8871 * License and copyright ownership: Same license as used throughout CGAL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
constvariables declared at global scope have internal linkage, and so if they are declared in a header file, they are replicated in every file that#includethe header. They also can't be the target ofusingdeclarations that exports the variable into a C++20 module. This change marks a number of variables withinline, which gives these variables external linkage, allows the linker to unify all of these variables between different.ofiles, and also allows for their use in C++20 modules.There is a separate question whether these variables could or should be
constexprinstead of justconst. The difference betweenconstexprandconsthas no effect on linkage, and so in the spirit of taking one step at a time, this patch does not address theconstexprvsconstquestion.This patch fixes #8871. Related to dealii/dealii#18071.
Release Management