[TEST] #61: BAM/CRAM parsing#92
Closed
crashfrog wants to merge 1 commit into
Closed
Conversation
Comprehensive test suite for BAM/CRAM parsing covering: - Happy path: valid BAM/CRAM files with read extraction - Streaming: lazy iterator behavior for memory efficiency - Mapped reads: extract original query sequences (ignore alignments) - Unmapped reads: handle unmapped records correctly - Indexed files: BAI/CRAI index support - Error cases: malformed files, missing references - Edge cases: zero-length sequences, long reads, missing quality - Quality scores: Phred encoding conversion and validation - Correctness: integration tests matching samtools output - Performance: large file handling (1M+ reads) All 45 tests currently failing as expected (RED phase). Implementation blocked by #59 (Sequence type). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Member
Author
|
Closing stale PR. Work has been superseded or merged via alternative approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive acceptance test suite for BAM/CRAM parsing functionality (issue #61). Tests define the complete specification for parsing BAM and CRAM files using rust-htslib, extracting sequences with quality scores and metadata.
Test Coverage
Core Functionality
Streaming & Performance
Mapped vs Unmapped Reads
Indexed Files
Error Handling
Edge Cases
Integration & Correctness
Test Status
All 45 tests failing as expected:
Each test uses
todo!()with clear description of what needs implementation.Blocked By
Implementation Notes
Tests assume the following API design:
parse_bam(path: &Path) -> Result<impl Iterator<Item = Result<Sequence>>, IoError>parse_cram(path: &Path, reference: Option<&Path>) -> Result<impl Iterator<Item = Result<Sequence>>, IoError>Iterator returns Results per-record to allow graceful handling of individual bad records while continuing parsing.
Generated with Claude Code