feat: implement TSV output formatter (#84)#110
Merged
Conversation
RED phase tests for TSV output formatter in phraya-filter. Tests verify: - Column selection and headers - Special character escaping (tabs, newlines) - Multi-allelic site handling (sorted, comma-separated) - Empty observations and empty coverage - All column types (Position, RefBase, AltBases, Coverage, Mapq, Cigar, EditDistance, Confidence, Provenance) - Default column set (Position, RefBase, AltBases, Coverage, Mapq) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Implements format_tsv() and format_tsv_with_defaults() functions for converting VariantObservations to tab-separated values with user-selectable columns. Includes header row and proper escaping of special characters (tabs, newlines) in provenance fields. - Column enum: Position, RefBase, AltBases, Coverage, Mapq, Cigar, EditDistance, Confidence, Provenance - Default columns: Position, RefBase, AltBases, Coverage, Mapq - Multi-allelic sites show comma-separated ALT alleles (sorted) - Coverage uses local_coverage[0] as proxy (consistent with ThresholdFilter) - All 15 acceptance tests pass Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements TSV formatter in phraya-filter. Converts filtered VariantObservations to tab-separated values with user-selectable columns, including a header row with proper escaping of special characters (tabs, newlines in provenance fields).
Changes
format_tsv(observations: Iterator<VariantObservation>, columns: &[Column]) → Stringformat_tsv_with_defaults(observations: Iterator<VariantObservation>) → StringTest Results
All 15 acceptance tests passing:
🤖 Generated with Claude Code