Skip to content

fix: update subject handling and access group mappings #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zubeydecivelek wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −6
Open

fix: update subject handling and access group mappings #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cds_migrator_kit/rdm/migration_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,7 @@ def resolve_record_pid(pid):
"HRDepExtended": ["hr-dep"],
"EligibilityHRCirc": ["eligibility-retr-actual", "hr-web-gacepa"],
"CERNPeopleEligibility": ["cern-personnel", "eligibility-retr-actual"],
"FAPDepRestrFile": ["fap-dep"],
Copy link
Copy Markdown
Contributor

@kpsherva kpsherva May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you verify if records are migrated with restricted file? should only the file be restricted or the whole record?

Copy link
Copy Markdown
Contributor Author

@zubeydecivelek zubeydecivelek May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all records are restricted. How can I verify if the restriction is record/file?

Copy link
Copy Markdown
Contributor

@kpsherva kpsherva May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can open the migrated record and check manually

# CERN E-guide restricted docs: https://cds.cern.ch/admin/webaccess/webaccessadmin.py/showroledetails?id_role=69 CERN personnel has view rights
}

Expand Down
4 changes: 4 additions & 0 deletions cds_migrator_kit/rdm/records/transform/xml_processing/rules/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,10 @@ def validate_subject_scheme(subject_scheme, subfield, key):

is_controlled_subject = key == "65017" and (scheme in CONTROLLED_SUBJECTS_SCHEMES)

# Drop other subjects
if val_a.lower().strip() == "other subjects":
raise IgnoreKey("subjects")

if type(val_a) is tuple:
# sometimes keywords are stick in one tag, so they come out as tuple
s_values = val_a
Expand Down
7 changes: 1 addition & 6 deletions cds_migrator_kit/rdm/records/transform/xml_processing/rules/hr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,11 +365,7 @@ def title(self, key, value):
self["additional_titles"] = alt_titles
identifiers = self.get("identifiers", [])
rep_num = next(
(
identifier
for identifier in identifiers
if identifier["scheme"] == "cdsrn"
),
(identifier for identifier in identifiers if identifier["scheme"] == "cdsrn"),
{},
).get("identifier")

Expand All @@ -393,7 +389,6 @@ def title(self, key, value):
return title



@model.over("meeting_cf", "^773__")
@for_each_value
def meeting(self, key, value):
Expand Down
Loading