add(staff-association): new model and transformation rules#391
add(staff-association): new model and transformation rules#391zubeydecivelek wants to merge 1 commit into
Conversation
zubeydecivelek
force-pushed
the
staff-assoc
branch
from
08ed04c to
888e70b
Compare
| "corresponding video": { | ||
| "relation_type": {"id": "references"}, | ||
| # TODO: do we need new resource type for video? | ||
| "resource_type": {"id": "audio"}, | ||
| }, |
There was a problem hiding this comment.
Example record: https://cds.cern.ch/record/1494034/
It's a digitized video record. What should be the resource_type? Do we need a new one?
There was a problem hiding this comment.
here is the PR:
CERNDocumentServer/cds-rdm#791
| "manuscript": { | ||
| "relation_type": {"id": "isderivedfrom"}, | ||
| "resource_type": {"id": "publication-preprint"}, | ||
| }, |
There was a problem hiding this comment.
Example record: https://cds.cern.ch/record/2846702
There was a problem hiding this comment.
is it the only record? because this particular one is not a preprint
There was a problem hiding this comment.
yes that's the only record
There was a problem hiding this comment.
then please check with the curators what it should be, this one seems incorrect
| if value == "bulletinstaff": | ||
| # TODO what is the resource type? | ||
| return {"id": "publication-periodicalarticle"} |
There was a problem hiding this comment.
Is resource_type correct?
zubeydecivelek
force-pushed
the
staff-assoc
branch
2 times, most recently
from
cd7693e to
ec6be3c
Compare
| identity, data=entry["record"]["json"] | ||
| ) | ||
| self._assign_rep_numbers(draft) | ||
| except ManualImportRequired as e: |
There was a problem hiding this comment.
to reach error message. I mentioned here but if it's fixed somewhere else, I'll remove it
There was a problem hiding this comment.
but the exception block below catches any exception and re-raises the same type of error, so it should not be needed
| "110__a", # corporate author, always CERN, safe to ignore | ||
| "300__a", # number of pages | ||
| "336__a", # DM metadata | ||
| "506__m", # 2120833, ignored with confirmation from IR-ECO-CO |
There was a problem hiding this comment.
does it mean we need to ask them?
There was a problem hiding this comment.
Ignore keys are copied from bulletin. But I can check them again and verify with library if it's needed
There was a problem hiding this comment.
I checked the rules, 506__m doesnt exist for staff association. But we need to figure out multiple submitters, most of the records(2595/3306) have 859__a with different values.
zubeydecivelek
force-pushed
the
staff-assoc
branch
from
ec6be3c to
ae3d8bb
Compare
zubeydecivelek
force-pushed
the
staff-assoc
branch
from
ae3d8bb to
2da547f
Compare
2 participants
No records found with
scripts/dump_legacy_recids_to_redirect.py