Skip to content

Add unit tests for validation#539

Open
robertandremitchell wants to merge 5 commits intomainfrom
rob/537-add-unit-tests-for-validation
Open

Add unit tests for validation#539
robertandremitchell wants to merge 5 commits intomainfrom
rob/537-add-unit-tests-for-validation

Conversation

@robertandremitchell
Copy link
Copy Markdown
Collaborator

@robertandremitchell robertandremitchell commented May 7, 2026

Description

Had some missing coverage on validation that this ought to address.

Related Issues

Closes #537

Additional Notes

[Add any additional context or notes that reviewers should know about.]

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@robertandremitchell robertandremitchell linked an issue May 7, 2026 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.06%. Comparing base (1110742) to head (5bca9c8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   95.81%   96.06%   +0.25%     
==========================================
  Files          46       46              
  Lines        2339     2339              
==========================================
+ Hits         2241     2247       +6     
+ Misses         98       92       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robertandremitchell robertandremitchell marked this pull request as ready for review May 7, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests for validation

2 participants