Expose count observation process base class; add section to tutorial for custom count observation process#726
Open
cdc-mitzimorris wants to merge 33 commits intomainfrom
Open
Expose count observation process base class; add section to tutorial for custom count observation process#726cdc-mitzimorris wants to merge 33 commits intomainfrom
cdc-mitzimorris wants to merge 33 commits intomainfrom
Conversation
… mem_h_e_tutorial
cdc-mitzimorris
requested review from
SamuelBrand1,
damonbayer and
dylanhmorris
as code owners
for more information, see https://pre-commit.ci
… into mem_custom_weekly_counts
|
Thank you for your contribution @cdc-mitzimorris 🚀! Your github-pages is ready for download 👉 here 👈! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
- Coverage 97.95% 97.95% -0.01%
==========================================
Files 51 51
Lines 1617 1615 -2
==========================================
- Hits 1584 1582 -2
Misses 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@dylanhmorris, @damonbayer - ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the Count observation process base class from
_CountBasetoCountBase- which parallels how the Measurements observation process class is set up.Add a section to tutorial
observation_process_counts.qmdshowing how to extent theCountBaseclass for observation data aggregated to the weekly level. This parallels how the Measurements observation process tutorial defines theWastewaterclass.