Brief Topological code refactor#40
Open
MitchLahm wants to merge 2 commits into
Open
Conversation
nlk36701
reviewed
Jun 26, 2026
Collaborator
There was a problem hiding this comment.
It looks like out-of-plane bends were removed from the delocalized internal coordinate scheme. Can it be added back?
Collaborator
Author
There was a problem hiding this comment.
I need to rename the _build_torsions function to _build_four_center, because I simply moved the code from the main body into the functions below. Thus, the out-of-plane bends are still there, just confusing :).
TL;DR This will be fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.