You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(wrapper): stop reporting success after failed dry-runs #151
When dryrun() pipes Snakemake output through tee, the wrapper prints OK Dry-run completed. even if Snakemake exits non-zero. The dry-run path should capture the pipeline exit status and only report success when the dry-run actually succeeds.
Acceptance Criteria
Failed Snakemake dry-runs do not print a success message.
The wrapper exits non-zero when the dry-run fails.
The change is validated with a failing dry-run case.
This issue is already resolved on main by PR #152.
The fix is present in merge commit e5ec35b, where dryrun() now enables pipefail, captures PIPESTATUS[0], exits non-zero on failure, and only prints the success message after a successful Snakemake dry-run.
Activity
kopardev commentedon Sep 25, 2026
This issue is already resolved on
mainby PR #152.The fix is present in merge commit
e5ec35b, wheredryrun()now enablespipefail, capturesPIPESTATUS[0], exits non-zero on failure, and only prints the success message after a successful Snakemake dry-run.Closing as resolved.
⚡ Generated using AI ⚡