Skip to content

fix(wrapper): stop reporting success after failed dry-runs #151

Closed

Description

@kopardev

Summary

When dryrun() pipes Snakemake output through tee, the wrapper prints OK Dry-run completed. even if Snakemake exits non-zero. The dry-run path should capture the pipeline exit status and only report success when the dry-run actually succeeds.

Acceptance Criteria

  • Failed Snakemake dry-runs do not print a success message.
  • The wrapper exits non-zero when the dry-run fails.
  • The change is validated with a failing dry-run case.

Parent issue: #127

⚡ Generated using AI ⚡

Activity

  1. kopardev commented on Sep 25, 2026

    @kopardev
    ContributorAuthor

    This issue is already resolved on main by PR #152.

    The fix is present in merge commit e5ec35b, where dryrun() now enables pipefail, captures PIPESTATUS[0], exits non-zero on failure, and only prints the success message after a successful Snakemake dry-run.

    Closing as resolved.

    ⚡ Generated using AI ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions